From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Cc: hch@infradead.org, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 2/4] nvme: split command copy into a helper
Date: Tue, 16 Nov 2021 20:38:05 -0700 [thread overview]
Message-ID: <20211117033807.185715-3-axboe@kernel.dk> (raw)
In-Reply-To: <20211117033807.185715-1-axboe@kernel.dk>
We'll need it for batched submit as well.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
drivers/nvme/host/pci.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c89f74ea00d4..c33cd1177b37 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -501,6 +501,15 @@ static inline void nvme_write_sq_db(struct nvme_queue *nvmeq, bool write_sq)
nvmeq->last_sq_tail = nvmeq->sq_tail;
}
+static inline void nvme_copy_cmd(struct nvme_queue *nvmeq,
+ struct nvme_command *cmd)
+{
+ memcpy(nvmeq->sq_cmds + (nvmeq->sq_tail << nvmeq->sqes), cmd,
+ sizeof(*cmd));
+ if (++nvmeq->sq_tail == nvmeq->q_depth)
+ nvmeq->sq_tail = 0;
+}
+
/**
* nvme_submit_cmd() - Copy a command into a queue and ring the doorbell
* @nvmeq: The queue to use
@@ -511,10 +520,7 @@ static void nvme_submit_cmd(struct nvme_queue *nvmeq, struct nvme_command *cmd,
bool write_sq)
{
spin_lock(&nvmeq->sq_lock);
- memcpy(nvmeq->sq_cmds + (nvmeq->sq_tail << nvmeq->sqes),
- cmd, sizeof(*cmd));
- if (++nvmeq->sq_tail == nvmeq->q_depth)
- nvmeq->sq_tail = 0;
+ nvme_copy_cmd(nvmeq, cmd);
nvme_write_sq_db(nvmeq, write_sq);
spin_unlock(&nvmeq->sq_lock);
}
--
2.33.1
next prev parent reply other threads:[~2021-11-17 3:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 3:38 [PATCHSET 0/4] Add support for list issue Jens Axboe
2021-11-17 3:38 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-11-17 6:25 ` Christoph Hellwig
2021-11-17 15:41 ` Jens Axboe
2021-11-17 8:20 ` Ming Lei
2021-11-17 15:43 ` Jens Axboe
2021-11-17 20:48 ` Keith Busch
2021-11-17 23:59 ` Ming Lei
2021-11-17 20:41 ` Keith Busch
2021-11-18 0:18 ` Ming Lei
2021-11-18 2:02 ` Keith Busch
2021-11-18 2:14 ` Ming Lei
2021-11-17 3:38 ` Jens Axboe [this message]
2021-11-17 6:15 ` [PATCH 2/4] nvme: split command copy into a helper Christoph Hellwig
2021-11-17 15:44 ` Jens Axboe
2021-11-18 7:54 ` Chaitanya Kulkarni
2021-11-17 3:38 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-11-17 6:17 ` Christoph Hellwig
2021-11-17 15:45 ` Jens Axboe
2021-11-18 7:59 ` Chaitanya Kulkarni
2021-11-17 3:38 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-11-17 8:39 ` Christoph Hellwig
2021-11-17 15:55 ` Jens Axboe
2021-11-17 15:58 ` Jens Axboe
2021-11-17 19:41 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2021-12-03 21:45 [PATCHSET v2 0/4] Add support for list issue Jens Axboe
2021-12-03 21:45 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-04 10:44 ` Hannes Reinecke
2021-12-06 7:38 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe
2021-12-16 16:05 [PATCHSET v4 0/4] Add support for list issue Jens Axboe
2021-12-16 16:05 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-16 16:38 [PATCHSET v5 0/4] Add support for list issue Jens Axboe
2021-12-16 16:38 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-12-16 17:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117033807.185715-3-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).