From: Christoph Hellwig <hch@lst.de>
To: Tim Walker <tim.t.walker@seagate.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
Yi Zhang <yi.zhang@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-mq: don't insert FUA request with data into scheduler queue
Date: Fri, 19 Nov 2021 17:56:27 +0100 [thread overview]
Message-ID: <20211119165627.GA15266@lst.de> (raw)
In-Reply-To: <3DEFF083-6C67-4864-81A5-454A7DAC16C0@seagate.com>
Direct reply without a quote a the formatting of your mail is completely
messed up. We don't treat a FUA a a flush. If the device supports
FUA is is just passed on. But if the device does not support FUA it
is sequenced into doing the write first and then a flush before returning
completion to the caller to guarantee the FUA semantics. Because of that
the command needs special treatment and be handed over to the flush
state machine, but it won't do anything interesting if FUA is actually
natively supported.
next prev parent reply other threads:[~2021-11-19 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 15:30 [PATCH] blk-mq: don't insert FUA request with data into scheduler queue Ming Lei
2021-11-18 18:22 ` Bart Van Assche
2021-11-19 6:08 ` Christoph Hellwig
2021-11-19 8:07 ` Ming Lei
2021-11-19 13:28 ` Jens Axboe
[not found] ` <BFC93946-13B3-43EC-9E30-8A980CD5234F@seagate.com>
2021-11-19 16:49 ` Tim Walker
2021-11-19 16:56 ` Christoph Hellwig [this message]
2021-11-19 17:49 ` Tim Walker
2021-11-20 3:58 ` Ming Lei
2021-11-23 16:11 ` Tim Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119165627.GA15266@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tim.t.walker@seagate.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox