public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Keith Busch <kbusch@kernel.org>,
	linux-block@vger.kernel.org, axboe@kernel.dk
Cc: kbuild-all@lists.01.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] blk-mq: check quiesce state before queue_rqs
Date: Tue, 21 Dec 2021 06:59:30 +0800	[thread overview]
Message-ID: <202112210618.hCiNGmq9-lkp@intel.com> (raw)
In-Reply-To: <20211220205412.151342-1-kbusch@kernel.org>

Hi Keith,

I love your patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on next-20211220]
[cannot apply to v5.16-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Keith-Busch/blk-mq-check-quiesce-state-before-queue_rqs/20211221-045504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211221/202112210618.hCiNGmq9-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8004ce63b95d4be66e4ad8655a05ee21a9a148d8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Keith-Busch/blk-mq-check-quiesce-state-before-queue_rqs/20211221-045504
        git checkout 8004ce63b95d4be66e4ad8655a05ee21a9a148d8
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> block/blk-mq.c:2552:6: warning: no previous prototype for '__blk_mq_flush_plug_list' [-Wmissing-prototypes]
    2552 | void __blk_mq_flush_plug_list(struct request_queue *q, struct blk_plug *plug)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/__blk_mq_flush_plug_list +2552 block/blk-mq.c

  2551	
> 2552	void __blk_mq_flush_plug_list(struct request_queue *q, struct blk_plug *plug)
  2553	{
  2554		if (blk_queue_quiesced(q))
  2555			return;
  2556		q->mq_ops->queue_rqs(&plug->mq_list);
  2557	}
  2558	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

      parent reply	other threads:[~2021-12-20 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 20:54 [PATCH] blk-mq: check quiesce state before queue_rqs Keith Busch
2021-12-20 20:56 ` Keith Busch
2021-12-20 22:59 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202112210618.hCiNGmq9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=kbuild-all@lists.01.org \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox