From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: null_blk: only set set->nr_maps as 3 if active poll_queues is > 0
Date: Fri, 24 Dec 2021 04:28:29 +0000 [thread overview]
Message-ID: <20211224042829.xwt3hifsne5asv3d@shindev> (raw)
In-Reply-To: <20211224010831.1521805-1-ming.lei@redhat.com>
On Dec 24, 2021 / 09:08, Ming Lei wrote:
> It isn't correct to set set->nr_maps as 3 if g_poll_queues is > 0 since
> we can change it via configfs for null_blk device created there, so only
> set it as 3 if active poll_queues is > 0.
>
> Fixes divide zero exception reported by Shinichiro.
>
> Fixes: 2bfdbe8b7ebd ("null_blk: allow zero poll queues")
> Reported-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Thanks for the fix. It looks good to me. Also, I confirmed the divide zero
exception is avoided with this patch.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2021-12-24 4:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 1:08 [PATCH] block: null_blk: only set set->nr_maps as 3 if active poll_queues is > 0 Ming Lei
2021-12-24 4:28 ` Shinichiro Kawasaki [this message]
2021-12-24 5:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211224042829.xwt3hifsne5asv3d@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox