Re: [PATCH V2] null_blk: allow zero poll queues

Jens Axboe
2021-12-24T00:55:35Z

On 12/23/21 5:52 PM, Shinichiro Kawasaki wrote:
> On Dec 03, 2021 / 21:09, Ming Lei wrote:
>> There isn't any reason to not allow zero poll queues from user
>> viewpoint.
>>
>> Also sometimes we need to compare io poll between poll mode and irq
>> mode, so not allowing poll queues is bad.
>>
>> Fixes: 15dfc662ef31 ("null_blk: Fix handling of submit_queues and poll_queues attributes")
>> Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
>> ---
>> V2:
>> - fix divide zero fault as reported by Shin'ichiro
>
> Jens, Ming,
>
> I find the V1 was applied to the for/5.17-drivers branch, and the additional fix
> in the V2 does not look applied to the branch. Do we need another small patch to
> cover the delta between V1 and V2?

Yes, please send an incremental, thanks.

--
Jens Axboe