From: Christoph Hellwig <hch@lst.de>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Christoph Hellwig <hch@lst.de>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH] make autoclear operation synchronous again
Date: Wed, 29 Dec 2021 18:29:02 +0100 [thread overview]
Message-ID: <20211229172902.GC27693@lst.de> (raw)
In-Reply-To: <03f43407-c34b-b7b2-68cd-d4ca93a993b8@i-love.sakura.ne.jp>
The subject line is missing the loop: prefix.
This approach looks very reasonable, but a few comments below:
> - lo->workqueue = alloc_workqueue("loop%d",
> - WQ_UNBOUND | WQ_FREEZABLE,
> - 0,
> - lo->lo_number);
> + if (!lo->workqueue)
> + lo->workqueue = alloc_workqueue("loop%d",
> + WQ_UNBOUND | WQ_FREEZABLE,
> + 0, lo->lo_number);
Instead of having to deal with sometimes present workqueues, why
not move the workqueue allocation to loop_add?
> + /* This is safe: open() is still holding a reference. */
> + module_put(THIS_MODULE);
Any reason to move the module_put here insted of keeping it at the
end of the function as the old code did?
next prev parent reply other threads:[~2021-12-29 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 7:06 [PATCH] make autoclear operation synchronous again Tetsuo Handa
2021-12-29 17:29 ` Christoph Hellwig [this message]
2021-12-30 10:52 ` Tetsuo Handa
2022-01-03 8:33 ` Christoph Hellwig
2022-01-05 6:02 ` Jan Stancek
2022-01-05 6:10 ` Tetsuo Handa
2022-01-20 8:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229172902.GC27693@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=schatzberg.dan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).