From: Daniel Wagner <dwagner@suse.de>
To: linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH 0/2] fix crash by reading /proc/diskstats
Date: Thu, 20 Jan 2022 11:52:46 +0100 [thread overview]
Message-ID: <20220120105248.117025-1-dwagner@suse.de> (raw)
During failover nvme-tcp tests in a HA setup a crash orccured. iostat
was running in the background while the test was executed.
I am not sure if the fix is correct. I am unsure if using
blk_queue_enter() is the right thing. But when starring at the code
snipped I saw in older version blk_queue_enter() was used but got
evenutally replaced by the rcu_read_lock() as far I understand at the
moment... So any tip here would be highly appreciated.
Daniel
Daniel Wagner (2):
block: remove commented out code from diskstats_show
block: hold queue lock while iterating in diskstats_show
block/genhd.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
--
2.29.2
next reply other threads:[~2022-01-20 10:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 10:52 Daniel Wagner [this message]
2022-01-20 10:52 ` [PATCH 1/2] block: remove commented out code from diskstats_show Daniel Wagner
2022-01-20 11:02 ` Hannes Reinecke
2022-03-04 15:38 ` Daniel Wagner
2022-01-20 10:52 ` [PATCH 2/2] block: hold queue lock while iterating in diskstats_show Daniel Wagner
2022-01-20 11:18 ` Hannes Reinecke
2022-01-20 12:41 ` Daniel Wagner
2022-01-20 12:56 ` Ming Lei
2022-01-20 13:19 ` Daniel Wagner
2022-01-20 13:51 ` Ming Lei
2022-01-20 14:01 ` Daniel Wagner
2022-01-20 14:06 ` Daniel Wagner
2022-01-20 14:21 ` Christoph Hellwig
2022-01-20 14:34 ` Daniel Wagner
2022-01-20 15:37 ` Ming Lei
2022-01-20 16:29 ` Daniel Wagner
2022-03-04 14:53 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120105248.117025-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).