From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29EBC433F5 for ; Mon, 24 Jan 2022 13:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243139AbiAXNQg (ORCPT ); Mon, 24 Jan 2022 08:16:36 -0500 Received: from verein.lst.de ([213.95.11.211]:55762 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243145AbiAXNQ1 (ORCPT ); Mon, 24 Jan 2022 08:16:27 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id DE3F268BEB; Mon, 24 Jan 2022 14:16:24 +0100 (CET) Date: Mon, 24 Jan 2022 14:16:24 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , "Martin K . Petersen" , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH V2 10/13] block: add helper of disk_release_queue for release queue data for disk Message-ID: <20220124131624.GI27269@lst.de> References: <20220122111054.1126146-1-ming.lei@redhat.com> <20220122111054.1126146-11-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220122111054.1126146-11-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Jan 22, 2022 at 07:10:51PM +0800, Ming Lei wrote: > Add one helper of disk_release_queue for releasing queue data for disk. Please explain what "queue data for disk" is, and why this helper is useful. Right now it seems to just move a few things around without a rationale or explanation of why it is safe.