From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70203C43219 for ; Tue, 25 Jan 2022 14:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1579625AbiAYOlm (ORCPT ); Tue, 25 Jan 2022 09:41:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1579776AbiAYOiw (ORCPT ); Tue, 25 Jan 2022 09:38:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478D4C061401; Tue, 25 Jan 2022 06:38:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0EB82B81812; Tue, 25 Jan 2022 14:38:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22EE7C340E0; Tue, 25 Jan 2022 14:38:48 +0000 (UTC) Date: Tue, 25 Jan 2022 09:38:46 -0500 From: Steven Rostedt To: Yang Shi Cc: Cong Wang , linux-block@vger.kernel.org, Linux Kernel Mailing List , Jens Axboe Subject: Re: [Patch v3] block: introduce block_rq_error tracepoint Message-ID: <20220125093846.59826cad@gandalf.local.home> In-Reply-To: <20220125093702.3ffdb721@gandalf.local.home> References: <20200203053650.8923-1-xiyou.wangcong@gmail.com> <20220125093702.3ffdb721@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, 25 Jan 2022 09:37:02 -0500 Steven Rostedt wrote: > > > +TRACE_EVENT(block_rq_error, > > > + > > > + TP_PROTO(struct request *rq, int error, unsigned int nr_bytes), > > > + > > > + TP_ARGS(rq, error, nr_bytes), > > > + > > > + TP_STRUCT__entry( > > > + __field( dev_t, dev ) > > > + __string( name, rq->rq_disk ? rq->rq_disk->disk_name : "?") > > > + __field( sector_t, sector ) > > > + __field( unsigned int, nr_sector ) > > > + __field( int, error ) > > > + __array( char, rwbs, RWBS_LEN ) > > Why is the above not "__string" ? > > > > + ), > > > + > > > + TP_fast_assign( > > > + __entry->dev = rq->rq_disk ? disk_devt(rq->rq_disk) : 0; > > > + __assign_str(name, rq->rq_disk ? rq->rq_disk->disk_name : "?"); > > __assign_str() will not work on an __array() type. It only works here > because you added it at the end, but it's just shear luck that it didn't > crash. Never mind :-p I see the above is for name which is __string, and the array is for rwbs which is filled below. I need to finish my first cup of coffee before reviewing patches. -- Steve > > > > > + __entry->sector = blk_rq_pos(rq); > > > + __entry->nr_sector = nr_bytes >> 9; > > > + __entry->error = error; > > > + > > > + blk_fill_rwbs(__entry->rwbs, rq->cmd_flags, nr_bytes); > > > + ), > > > + > > > + TP_printk("%d,%d %s %s %llu + %u [%d]", > > > + MAJOR(__entry->dev), MINOR(__entry->dev), > > > + __get_str(name), __entry->rwbs, > > > + (unsigned long long)__entry->sector, > > > + __entry->nr_sector, __entry->error) > > > +); > > > +