linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	drbd-dev@lists.linbit.com
Subject: [PATCH 09/14] dm: add a missing bio initialization to alloc_tio
Date: Thu, 27 Jan 2022 07:35:41 +0100	[thread overview]
Message-ID: <20220127063546.1314111-10-hch@lst.de> (raw)
In-Reply-To: <20220127063546.1314111-1-hch@lst.de>

The bio in the tio embedded into the clone_info structure is never
initialized.  This is harmless as bio_init only zeroes the structure
and assigns the vectors, but add the initialization to prepare for
refactoring the bio cloning logic.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index ee2d92ec7c9fc..57f44d3a4d747 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -552,6 +552,7 @@ static struct bio *alloc_tio(struct clone_info *ci, struct dm_target *ti,
 	if (!ci->io->tio.io) {
 		/* the dm_target_io embedded in ci->io is available */
 		tio = &ci->io->tio;
+		bio_init(&tio->clone, NULL, NULL, 0, 0);
 	} else {
 		struct bio *clone = bio_alloc_bioset(NULL, 0, 0, gfp_mask,
 						     &ci->io->md->bs);
-- 
2.30.2


  parent reply	other threads:[~2022-01-27  6:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27  6:35 improve the bio cloning interface Christoph Hellwig
2022-01-27  6:35 ` [PATCH 01/14] drbd: set ->bi_bdev in drbd_req_new Christoph Hellwig
2022-01-27  6:35 ` [PATCH 02/14] dm: add a clone_to_tio helper Christoph Hellwig
2022-01-27  6:35 ` [PATCH 03/14] dm: fold clone_bio into __clone_and_map_data_bio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 04/14] dm: fold __send_duplicate_bios into __clone_and_map_simple_bio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 05/14] dm: move cloning the bio into alloc_tio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 06/14] dm: pass the bio instead of tio to __map_bio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 07/14] dm: retun the clone bio from alloc_tio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 08/14] dm: simplify the single bio fast path in __send_duplicate_bios Christoph Hellwig
2022-01-27  6:35 ` Christoph Hellwig [this message]
2022-01-27  6:35 ` [PATCH 10/14] dm-cache: remove __remap_to_origin_clear_discard Christoph Hellwig
2022-01-27  6:35 ` [PATCH 11/14] block: clone crypto and integrity data in __bio_clone_fast Christoph Hellwig
2022-01-27  6:35 ` [PATCH 12/14] dm: use bio_clone_fast in alloc_tio Christoph Hellwig
2022-01-27  6:35 ` [PATCH 13/14] block: initialize the target bio in __bio_clone_fast Christoph Hellwig
2022-01-27  6:35 ` [PATCH 14/14] block: pass a block_device to bio_clone_fast Christoph Hellwig
2022-01-27 16:52 ` improve the bio cloning interface Mike Snitzer
2022-01-27 19:58   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220127063546.1314111-10-hch@lst.de \
    --to=hch@lst.de \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).