Re: [PATCH 0/8] loop: cleanup and few improvements

Jens Axboe
2022-02-14T13:47:02Z

On 2/14/22 3:01 AM, Chaitanya Kulkarni wrote:
> Hi,
>
> This has few improvment and cleanups such as using sysfs_emit() for the
> sysfs dev attributes and removing variables that are only used once and
> a cleanup with fixing declaration.
>
> Below is the test log where 10 loop devices created, each device is
> linked to it's own file in ./loopX, formatted with xfs and mounted on
> /mnt/loopX. For each device it reads the offset, sizelimit, autoclear,
> partscan, and dio attr from sysfs using cat command, then it runs fio
> verify job on it.
>
> In summary write-verify fio job seems to work fine :-
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=3495: Mon Feb 14 00:43:19 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=3960: Mon Feb 14 00:45:17 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4321: Mon Feb 14 00:47:15 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4369: Mon Feb 14 00:49:20 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4443: Mon Feb 14 00:51:25 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4536: Mon Feb 14 00:53:25 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4770: Mon Feb 14 00:55:24 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=4933: Mon Feb 14 00:57:31 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=5008: Mon Feb 14 00:59:35 2022
> write-and-verify: (groupid=0, jobs=1): err= 0: pid=5048: Mon Feb 14 01:01:58 2022
>
> Below is detailed test log.
>
> Chaitanya Kulkarni (8):
> loop: use sysfs_emit() in the sysfs offset show
> loop: use sysfs_emit() in the sysfs sizelimit show
> loop: use sysfs_emit() in the sysfs autoclear show
> loop: use sysfs_emit() in the sysfs partscan show
> loop: use sysfs_emit() in the sysfs dio show
> loop: remove extra variable in lo_fallocate()
> loop: remove extra variable in lo_req_flush
> loop: allow user to set the queue depth

Please collapse patches 1..5.

--
Jens Axboe