From: Christoph Hellwig <hch@lst.de>
To: "Markus Blöchl" <Markus.Bloechl@ipetronik.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, kbusch@kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: fix surprise removal for drivers calling blk_set_queue_dying
Date: Wed, 16 Feb 2022 19:10:40 +0100 [thread overview]
Message-ID: <20220216181040.GA21665@lst.de> (raw)
In-Reply-To: <20220216180850.fjcmj5yinaqolskt@ipetronik.com>
On Wed, Feb 16, 2022 at 07:08:50PM +0100, Markus Blöchl wrote:
> I noticed that set_capacity() is also called most of the time when
> a disk is killed. Should we also move that into blk_mark_disk_dead()?
> Any reasons not to?
I thought about that and I think it is a good idea. But for now I'd
keep the regression fix minimal and then do that as a next step.
next prev parent reply other threads:[~2022-02-16 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 15:09 [PATCH 1/2] block: fix surprise removal for drivers calling blk_set_queue_dying Christoph Hellwig
2022-02-16 15:09 ` [PATCH 2/2] block: skip the fsync_bdev call in del_gendisk for surprise removals Christoph Hellwig
2022-02-16 15:18 ` Hannes Reinecke
2022-02-16 15:20 ` Christoph Hellwig
2022-02-16 15:31 ` Hannes Reinecke
2022-02-16 15:32 ` Markus Blöchl
2022-02-16 17:09 ` Christoph Hellwig
2022-02-16 15:37 ` Keith Busch
2022-02-16 15:45 ` Christoph Hellwig
2022-02-16 15:32 ` [PATCH 1/2] block: fix surprise removal for drivers calling blk_set_queue_dying Hannes Reinecke
2022-02-16 15:49 ` Markus Blöchl
2022-02-16 17:09 ` Christoph Hellwig
2022-02-16 18:08 ` Markus Blöchl
2022-02-16 18:10 ` Christoph Hellwig [this message]
2022-02-16 17:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216181040.GA21665@lst.de \
--to=hch@lst.de \
--cc=Markus.Bloechl@ipetronik.com \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).