Re: [PATCH 05/10] nvdimm-blk: use bvec_kmap_local in nd_blk_rw_integrity

Ira Weiny
2022-03-01T03:54:27Z

On Tue, Feb 22, 2022 at 04:51:51PM +0100, Christoph Hellwig wrote:
> Using local kmaps slightly reduces the chances to stray writes, and
> the bvec interface cleans up the code a little bit.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
> drivers/nvdimm/blk.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvdimm/blk.c b/drivers/nvdimm/blk.c
> index c1db43524d755..0a38738335941 100644
> --- a/drivers/nvdimm/blk.c
> +++ b/drivers/nvdimm/blk.c
> @@ -88,10 +88,9 @@ static int nd_blk_rw_integrity(struct nd_namespace_blk *nsblk,
> */
>
> cur_len = min(len, bv.bv_len);
> - iobuf = kmap_atomic(bv.bv_page);
> - err = ndbr->do_io(ndbr, dev_offset, iobuf + bv.bv_offset,
> - cur_len, rw);
> - kunmap_atomic(iobuf);
> + iobuf = bvec_kmap_local(&bv);
> + err = ndbr->do_io(ndbr, dev_offset, iobuf, cur_len, rw);
> + kunmap_local(iobuf);
> if (err)
> return err;
>
> --
> 2.30.2
>
>