From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71477C433F5 for ; Wed, 2 Mar 2022 14:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234615AbiCBOtv (ORCPT ); Wed, 2 Mar 2022 09:49:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbiCBOtu (ORCPT ); Wed, 2 Mar 2022 09:49:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 617A72B180 for ; Wed, 2 Mar 2022 06:49:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646232546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wHHQjXlT6tUt0Lss/rsnIUmQeXIsRrXfl5Haz5wji5M=; b=KLL2koRgQYd8TWObRxbpFk7KiEdoEhq3t3F+zy39hfydlHaBWj0Hyy0ofoz54IgbAKPds7 YHfAkrAxpedu2RrUHqVgybKPXyqDUqX5f3/jywonJkQcD5iDxDxE6JFe4J7b+vPiwy+Bg0 t9qvjEzUVN1Gdab4f7tMWduz1Adr4hY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-215-4BxXRNBVMHmUZxvZWMDj_g-1; Wed, 02 Mar 2022 09:49:05 -0500 X-MC-Unique: 4BxXRNBVMHmUZxvZWMDj_g-1 Received: by mail-wm1-f72.google.com with SMTP id bg33-20020a05600c3ca100b00380dee8a62cso603682wmb.8 for ; Wed, 02 Mar 2022 06:49:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wHHQjXlT6tUt0Lss/rsnIUmQeXIsRrXfl5Haz5wji5M=; b=mv6R7/HjJQWM2JNLkTbmvqcfTyGtrZy/VM8l+fF+P61Wx4Taq6LF/Ejm+vs+3AS6E0 TeHasilFmQyJ1qPHrfccUuhpPTLtruiPdGq34ppYXDD0Bg622nvMg+C4vIRSRxj6+E2R h/1tuAaaDO0xqUKmRnK0mLSD8noP5PCtNNWbdOOhW8dPy6Ce5ZGNTDeEn+bNu3COXVyH sRszRVihr0uur8hNZ+gGFqSCrtZAeMXyNngE10XtJh5WUPeAmFmXSKLm92Pxi5IQEtst rplu5rzwm2vMfgmbWuLDV3JBjUbhqZgRAHX0dOlUVxhsSokFSwQ0b7cLTFxomI7DVOtg kBOw== X-Gm-Message-State: AOAM533tm4NyOWejgKxcizb1VLRQejEeTLOC5IciDaLI0JyvW/TK/XMi ojGY6dcVg8+xlE8Lfif1Lf3f+PaVCH9u8qCXLEDSfpyglTs2qlN222SivYwmIqjbOL/GED2fD7s 55EASKjPPruoD1SLAqIMYhrY= X-Received: by 2002:a05:600c:350f:b0:381:738e:d678 with SMTP id h15-20020a05600c350f00b00381738ed678mr111830wmq.124.1646232543982; Wed, 02 Mar 2022 06:49:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuTmZVcJrQP/d/f139cG8iFYYX3GPIlF1MI4SjHfgaw2CyO3pVi7ZRR9cj841RZf2dkATnBQ== X-Received: by 2002:a05:600c:350f:b0:381:738e:d678 with SMTP id h15-20020a05600c350f00b00381738ed678mr111811wmq.124.1646232543681; Wed, 02 Mar 2022 06:49:03 -0800 (PST) Received: from redhat.com ([2a10:8006:355c:0:48d6:b937:2fb9:b7de]) by smtp.gmail.com with ESMTPSA id m12-20020a7bcb8c000000b003811afe1d45sm5726051wmi.37.2022.03.02.06.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 06:49:03 -0800 (PST) Date: Wed, 2 Mar 2022 09:48:59 -0500 From: "Michael S. Tsirkin" To: Max Gurtovoy Cc: Xie Yongji , jasowang@redhat.com, axboe@kernel.dk, hch@infradead.org, virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org Subject: Re: [PATCH v2] virtio-blk: Remove BUG_ON() in virtio_queue_rq() Message-ID: <20220302094804-mutt-send-email-mst@kernel.org> References: <20220228065720.100-1-xieyongji@bytedance.com> <20220301104039-mutt-send-email-mst@kernel.org> <85e61a65-4f76-afc0-272f-3b13333349f1@nvidia.com> <20220302081542-mutt-send-email-mst@kernel.org> <20220302083112-mutt-send-email-mst@kernel.org> <808fbd57-588d-03e3-2904-513f4bdcceaf@nvidia.com> <20220302085132-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 02, 2022 at 04:27:15PM +0200, Max Gurtovoy wrote: > > On 3/2/2022 4:15 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 02, 2022 at 03:45:10PM +0200, Max Gurtovoy wrote: > > > On 3/2/2022 3:33 PM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 02, 2022 at 03:24:51PM +0200, Max Gurtovoy wrote: > > > > > On 3/2/2022 3:17 PM, Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 02, 2022 at 11:51:27AM +0200, Max Gurtovoy wrote: > > > > > > > On 3/1/2022 5:43 PM, Michael S. Tsirkin wrote: > > > > > > > > On Mon, Feb 28, 2022 at 02:57:20PM +0800, Xie Yongji wrote: > > > > > > > > > Currently we have a BUG_ON() to make sure the number of sg > > > > > > > > > list does not exceed queue_max_segments() in virtio_queue_rq(). > > > > > > > > > However, the block layer uses queue_max_discard_segments() > > > > > > > > > instead of queue_max_segments() to limit the sg list for > > > > > > > > > discard requests. So the BUG_ON() might be triggered if > > > > > > > > > virtio-blk device reports a larger value for max discard > > > > > > > > > segment than queue_max_segments(). > > > > > > > > Hmm the spec does not say what should happen if max_discard_seg > > > > > > > > exceeds seg_max. Is this the config you have in mind? how do you > > > > > > > > create it? > > > > > > > I don't think it's hard to create it. Just change some registers in the > > > > > > > device. > > > > > > > > > > > > > > But with the dynamic sgl allocation that I added recently, there is no > > > > > > > problem with this scenario. > > > > > > Well the problem is device says it can't handle such large descriptors, > > > > > > I guess it works anyway, but it seems scary. > > > > > I don't follow. > > > > > > > > > > The only problem this patch solves is when a virtio blk device reports > > > > > larger value for max_discard_segments than max_segments. > > > > > > > > > No, the peroblem reported is when virtio blk device reports > > > > max_segments < 256 but not max_discard_segments. > > > You mean the code will work in case device report max_discard_segments  > > > > max_segments ? > > > > > > I don't think so. > > I think it's like this: > > > > > > if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > > > > .... > > > > virtio_cread(vdev, struct virtio_blk_config, max_discard_seg, > > &v); > > blk_queue_max_discard_segments(q, > > min_not_zero(v, > > MAX_DISCARD_SEGMENTS)); > > > > } > > > > so, IIUC the case is of a device that sets max_discard_seg to 0. > > > > Which is kind of broken, but we handled this since 2018 so I guess > > we'll need to keep doing that. > > A device can't state VIRTIO_BLK_F_DISCARD and set max_discard_seg to 0. > > If so, it's a broken device and we can add a quirk for it. Well we already have min_not_zero there, presumably for some reason. > Do you have such device to test ? Xie Yongji mentioned he does. > > > > > This is exactly what Xie Yongji mention in the commit message and what I was > > > seeing. > > > > > > But the code will work if VIRTIO_BLK_F_DISCARD is not supported by the > > > device (even if max_segments < 256) , since blk layer set > > > queue_max_discard_segments = 1 in the initialization. > > > > > > And the virtio-blk driver won't change it unless VIRTIO_BLK_F_DISCARD is > > > supported. > > > > > > > I would expect discard to follow max_segments restrictions then. > > > > > > > > > Probably no such devices, but we need to be prepared. > > > > Right, question is how to handle this. > > > > > > > > > > > This commit looks good to me, thanks Xie Yongji. > > > > > > > > > > > > > > Reviewed-by: Max Gurtovoy > > > > > > > > > > > > > > > > To fix it, let's simply > > > > > > > > > remove the BUG_ON() which has become unnecessary after commit > > > > > > > > > 02746e26c39e("virtio-blk: avoid preallocating big SGL for data"). > > > > > > > > > And the unused vblk->sg_elems can also be removed together. > > > > > > > > > > > > > > > > > > Fixes: 1f23816b8eb8 ("virtio_blk: add discard and write zeroes support") > > > > > > > > > Suggested-by: Christoph Hellwig > > > > > > > > > Signed-off-by: Xie Yongji > > > > > > > > > --- > > > > > > > > > drivers/block/virtio_blk.c | 10 +--------- > > > > > > > > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > > > > > > > > > index c443cd64fc9b..a43eb1813cec 100644 > > > > > > > > > --- a/drivers/block/virtio_blk.c > > > > > > > > > +++ b/drivers/block/virtio_blk.c > > > > > > > > > @@ -76,9 +76,6 @@ struct virtio_blk { > > > > > > > > > */ > > > > > > > > > refcount_t refs; > > > > > > > > > - /* What host tells us, plus 2 for header & tailer. */ > > > > > > > > > - unsigned int sg_elems; > > > > > > > > > - > > > > > > > > > /* Ida index - used to track minor number allocations. */ > > > > > > > > > int index; > > > > > > > > > @@ -322,8 +319,6 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx, > > > > > > > > > blk_status_t status; > > > > > > > > > int err; > > > > > > > > > - BUG_ON(req->nr_phys_segments + 2 > vblk->sg_elems); > > > > > > > > > - > > > > > > > > > status = virtblk_setup_cmd(vblk->vdev, req, vbr); > > > > > > > > > if (unlikely(status)) > > > > > > > > > return status; > > > > > > > > > @@ -783,8 +778,6 @@ static int virtblk_probe(struct virtio_device *vdev) > > > > > > > > > /* Prevent integer overflows and honor max vq size */ > > > > > > > > > sg_elems = min_t(u32, sg_elems, VIRTIO_BLK_MAX_SG_ELEMS - 2); > > > > > > > > > - /* We need extra sg elements at head and tail. */ > > > > > > > > > - sg_elems += 2; > > > > > > > > > vdev->priv = vblk = kmalloc(sizeof(*vblk), GFP_KERNEL); > > > > > > > > > if (!vblk) { > > > > > > > > > err = -ENOMEM; > > > > > > > > > @@ -796,7 +789,6 @@ static int virtblk_probe(struct virtio_device *vdev) > > > > > > > > > mutex_init(&vblk->vdev_mutex); > > > > > > > > > vblk->vdev = vdev; > > > > > > > > > - vblk->sg_elems = sg_elems; > > > > > > > > > INIT_WORK(&vblk->config_work, virtblk_config_changed_work); > > > > > > > > > @@ -853,7 +845,7 @@ static int virtblk_probe(struct virtio_device *vdev) > > > > > > > > > set_disk_ro(vblk->disk, 1); > > > > > > > > > /* We can handle whatever the host told us to handle. */ > > > > > > > > > - blk_queue_max_segments(q, vblk->sg_elems-2); > > > > > > > > > + blk_queue_max_segments(q, sg_elems); > > > > > > > > > /* No real sector limit. */ > > > > > > > > > blk_queue_max_hw_sectors(q, -1U); > > > > > > > > > -- > > > > > > > > > 2.20.1