From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: move more work to disk_release v2
Date: Thu, 3 Mar 2022 11:54:55 +0100 [thread overview]
Message-ID: <20220303105455.GA14991@lst.de> (raw)
In-Reply-To: <9e818df5-e8c0-b397-ae21-1a0745074094@acm.org>
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
On Wed, Mar 02, 2022 at 03:33:35PM -0800, Bart Van Assche wrote:
> Thanks for having published a merge of block-for-next and the branch with
> this patch series. That makes it easy for me to replicate your kernel tree.
> I can reproduce the null-ptr-deref with the freeze-for-next branch but not
> with Jens' block-for-next branch (commit e70f36e84f9b ("Merge branch
> 'for-5.18/block' into for-next")). This is what appears in the kernel log
> on my test setup for the freeze-for-next branch (commit acac349e5516
> ("block: move rq_qos_exit() into disk_release()"):
>
> BUG: KASAN: null-ptr-deref in __blk_account_io_start+0x28/0xa0
>
> Maybe we are using different kernel configurations? I'm using
> CONFIG_NVME_MULTIPATH=n. I guess that you are using
> CONFIG_NVME_MULTIPATH=y?
Your testcases errors out when CONFIG_NVME_MULTIPATH=y is set, and
also requires various things to be built modular which wasted a lot
of my time yesterday trying to get that test to run. My .config
is below. Maybe you can try to figure out what derefernce causes
the null-ptr-deref, and what kind of command causes this? Also
I suspect this is the first patch in the series, so it would be
great to verify the problem with just that.
[-- Attachment #2: config.blktests.gz --]
[-- Type: application/x-gzip, Size: 37564 bytes --]
next prev parent reply other threads:[~2022-03-03 10:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 17:21 move more work to disk_release v2 Christoph Hellwig
2022-02-27 17:21 ` [PATCH 01/14] blk-mq: do not include passthrough requests in I/O accounting Christoph Hellwig
2022-02-27 17:21 ` [PATCH 02/14] blk-mq: handle already freed tags gracefully in blk_mq_free_rqs Christoph Hellwig
2022-02-27 17:21 ` [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver Christoph Hellwig
2022-02-27 17:21 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
2022-02-27 17:21 ` [PATCH 05/14] sd: call sd_zbc_release_disk before releasing the scsi_device reference Christoph Hellwig
2022-02-27 17:21 ` [PATCH 06/14] sd: delay calling free_opal_dev Christoph Hellwig
2022-02-27 17:21 ` [PATCH 07/14] sd: make use of ->free_disk to simplify refcounting Christoph Hellwig
2022-02-27 17:21 ` [PATCH 08/14] sr: implement ->free_disk Christoph Hellwig
2022-02-27 17:21 ` [PATCH 09/14] block: move blkcg initialization/destroy into disk allocation/release handler Christoph Hellwig
2022-02-27 17:21 ` [PATCH 10/14] block: don't remove hctx debugfs dir from blk_mq_exit_queue Christoph Hellwig
2022-02-27 17:21 ` [PATCH 11/14] block: move q_usage_counter release into blk_queue_release Christoph Hellwig
2022-02-27 17:21 ` [PATCH 12/14] block: move blk_exit_queue into disk_release Christoph Hellwig
2022-02-27 17:21 ` [PATCH 13/14] block: do more work in elevator_exit Christoph Hellwig
2022-02-27 17:21 ` [PATCH 14/14] block: move rq_qos_exit() into disk_release() Christoph Hellwig
2022-02-27 23:18 ` move more work to disk_release v2 Bart Van Assche
2022-03-01 12:56 ` Christoph Hellwig
2022-03-02 5:05 ` Bart Van Assche
2022-03-02 15:03 ` Christoph Hellwig
2022-03-02 23:33 ` Bart Van Assche
2022-03-03 10:54 ` Christoph Hellwig [this message]
2022-03-03 18:19 ` Bart Van Assche
2022-03-03 19:23 ` Christoph Hellwig
2022-03-03 20:51 ` Bart Van Assche
2022-03-01 13:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303105455.GA14991@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).