Re: [PATCH V3 5/6] blk-mq: prepare for implementing hctx table via xarray

Hannes Reinecke
2022-03-07T07:38:08Z

On 3/7/22 07:44, Ming Lei wrote:
> It is inevitable to cause use-after-free on q->queue_hw_ctx between
> queue_for_each_hw_ctx() and blk_mq_update_nr_hw_queues(). And converting
> to xarray can fix the uaf, meantime code gets cleaner.
>
> Prepare for converting q->queue_hctx_ctx into xarray, one thing is that
> xa_for_each() can only accept 'unsigned long' as index, so changes type
> of hctx index of queue_for_each_hw_ctx() into 'unsigned long'.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/blk-mq-debugfs.c | 6 +++---
> block/blk-mq-sched.c | 9 +++++----
> block/blk-mq-sysfs.c | 16 ++++++++++------
> block/blk-mq-tag.c | 2 +-
> block/blk-mq.c | 30 ++++++++++++++++--------------
> drivers/block/rnbd/rnbd-clt.c | 2 +-
> 6 files changed, 36 insertions(+), 29 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer