From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk
Cc: ming.lei@redhat.com, hch@lst.de, dm-devel@redhat.com,
linux-block@vger.kernel.org
Subject: [PATCH v6 0/2] block/dm: support bio polling
Date: Mon, 7 Mar 2022 13:53:01 -0500 [thread overview]
Message-ID: <20220307185303.71201-1-snitzer@redhat.com> (raw)
Hi,
I've rebased Ming's latest [1] ontop of dm-5.18 [2] (which is based on
for-5.18/block). End result available in dm-5.18-biopoll branch [3]
These changes add bio polling support to DM. Tested with linear and
striped DM targets.
IOPS improvement was ~5% on my baremetal system with a single Intel
Optane NVMe device (561K hipri=1 vs 530K hipri=0).
Ming has seen better improvement while testing within a VM:
dm-linear: hipri=1 vs hipri=0 15~20% iops improvement
dm-stripe: hipri=1 vs hipri=0 ~30% iops improvement
I'd like to merge these changes via the DM tree when the 5.18 merge
window opens. The first block patch that adds ->poll_bio to
block_device_operations will need review so that I can take it
through the DM tree. Reason for going through the DM tree is there
have been some fairly extensive changes queued in dm-5.18 that build
on for-5.18/block. So I think it easiest to just add the block
depenency via DM tree since DM is first consumer of ->poll_bio
Thanks,
Mike
[1] https://github.com/ming1/linux/commits/my_v5.18-dm-bio-poll
[2] https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.18
[3] https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.18-biopoll
[4] https://github.com/ming1/linux/commit/c107c30e15041ac1ce672f56809961406e2a3e52
v6: Ming switched from reusing .bi_end_io to .bi_private and added a
comment to comment-block above dm_get_bio_hlist_head as suggested
by Jens.
v5: remove WARN_ONs in ->poll_bio interface patch. Fixed comment typo
along the way (found while seeing how other
block_device_operations are referenced in block's code comments).
Ming Lei (2):
block: add ->poll_bio to block_device_operations
dm: support bio polling
block/blk-core.c | 14 +++--
block/genhd.c | 4 ++
drivers/md/dm-core.h | 2 +
drivers/md/dm-table.c | 27 ++++++++++
drivers/md/dm.c | 143 +++++++++++++++++++++++++++++++++++++++++++++++--
include/linux/blkdev.h | 2 +
6 files changed, 184 insertions(+), 8 deletions(-)
--
2.15.0
next reply other threads:[~2022-03-07 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 18:53 Mike Snitzer [this message]
2022-03-07 18:53 ` [PATCH v6 1/2] block: add ->poll_bio to block_device_operations Mike Snitzer
2022-03-09 1:01 ` Jens Axboe
2022-03-07 18:53 ` [PATCH v6 2/2] dm: support bio polling Mike Snitzer
2022-03-09 1:02 ` Jens Axboe
2022-03-09 1:13 ` Ming Lei
2022-03-09 16:11 ` Jens Axboe
2022-03-10 4:00 ` Ming Lei
2022-03-10 4:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307185303.71201-1-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox