From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: [PATCH 14/14] block: move rq_qos_exit() into disk_release()
Date: Tue, 8 Mar 2022 06:52:00 +0100 [thread overview]
Message-ID: <20220308055200.735835-15-hch@lst.de> (raw)
In-Reply-To: <20220308055200.735835-1-hch@lst.de>
From: Ming Lei <ming.lei@redhat.com>
Keep all teardown of file system I/O related functionality in one place.
There can't be file system I/O in disk_release(), so it is safe to move
rq_qos_exit() there.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/genhd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 857e0a54da7dd..56f66c6fee943 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -627,7 +627,6 @@ void del_gendisk(struct gendisk *disk)
blk_mq_freeze_queue_wait(q);
- rq_qos_exit(q);
blk_sync_queue(q);
blk_flush_integrity();
/*
@@ -1119,7 +1118,7 @@ static void disk_release_mq(struct request_queue *q)
elevator_exit(q);
mutex_unlock(&q->sysfs_lock);
}
-
+ rq_qos_exit(q);
__blk_mq_unfreeze_queue(q, true);
}
--
2.30.2
next prev parent reply other threads:[~2022-03-08 5:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 5:51 move more work to disk_release v4 Christoph Hellwig
2022-03-08 5:51 ` [PATCH 01/14] blk-mq: do not include passthrough requests in I/O accounting Christoph Hellwig
2022-03-08 5:51 ` [PATCH 02/14] blk-mq: handle already freed tags gracefully in blk_mq_free_rqs Christoph Hellwig
2022-03-08 5:51 ` [PATCH 03/14] scsi: don't use disk->private_data to find the scsi_driver Christoph Hellwig
2022-03-08 5:51 ` [PATCH 04/14] sd: rename the scsi_disk.dev field Christoph Hellwig
2022-03-08 5:51 ` [PATCH 05/14] sd: call sd_zbc_release_disk before releasing the scsi_device reference Christoph Hellwig
2022-03-08 5:51 ` [PATCH 06/14] sd: delay calling free_opal_dev Christoph Hellwig
2022-03-08 5:51 ` [PATCH 07/14] sd: implement ->free_disk to simplify refcounting Christoph Hellwig
2022-03-09 4:39 ` Bart Van Assche
2022-03-08 5:51 ` [PATCH 08/14] sr: " Christoph Hellwig
2022-03-08 5:51 ` [PATCH 09/14] block: move blkcg initialization/destroy into disk allocation/release handler Christoph Hellwig
2022-03-08 5:51 ` [PATCH 10/14] block: don't remove hctx debugfs dir from blk_mq_exit_queue Christoph Hellwig
2022-03-08 5:51 ` [PATCH 11/14] block: move q_usage_counter release into blk_queue_release Christoph Hellwig
2022-03-08 5:51 ` [PATCH 12/14] block: move blk_exit_queue into disk_release Christoph Hellwig
2022-03-08 5:51 ` [PATCH 13/14] block: do more work in elevator_exit Christoph Hellwig
2022-03-08 5:52 ` Christoph Hellwig [this message]
2022-03-09 0:58 ` move more work to disk_release v4 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-03-04 16:03 move more work to disk_release v3 Christoph Hellwig
2022-03-04 16:03 ` [PATCH 14/14] block: move rq_qos_exit() into disk_release() Christoph Hellwig
2022-03-06 20:51 ` Bart Van Assche
2022-03-07 2:50 ` Ming Lei
2022-02-27 17:21 move more work to disk_release v2 Christoph Hellwig
2022-02-27 17:21 ` [PATCH 14/14] block: move rq_qos_exit() into disk_release() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308055200.735835-15-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox