Re: [PATCH] block/psi: remove PSI annotations from submit_bio

Johannes Weiner
2022-03-09T19:18:35Z

On Wed, Mar 09, 2022 at 09:43:24AM +0000, cgel.zte@gmail.com wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> psi tracks the time spent submitting the IO of refaulting pages[1].
> But after we tracks refault stalls from swap_readpage[2][3], there
> is no need to do so anymore. Since swap_readpage already includes
> IO submitting time.
>
> [1] commit b8e24a9300b0 ("block: annotate refault stalls from IO submission")
> [2] commit 937790699be9 ("mm/page_io.c: annotate refault stalls from swap_readpage")
> [3] commit 2b413a1a728f ("mm: page_io: fix psi memory pressure error on cold swapins")
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> Reviewed-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>

It's still needed by file cache refaults!

NAK