Re: [PATCH 17/17] nvme: enable non-inline passthru commands

Christoph Hellwig
2022-03-10T08:37:22Z

On Tue, Mar 08, 2022 at 08:51:05PM +0530, Kanchan Joshi wrote:
> From: Anuj Gupta <anuj20.g@samsung.com>
>
> On submission,just fetch the commmand from userspace pointer and reuse
> everything else. On completion, update the result field inside the
> passthru command.

What is that supposed to mean? What is the reason to do it. Remember
to always document the why in commit logs.

>
> +static inline bool is_inline_rw(struct io_uring_cmd *ioucmd, struct nvme_command *cmd)

Overly long line.