From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D115C433F5 for ; Wed, 30 Mar 2022 05:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242677AbiC3FEM (ORCPT ); Wed, 30 Mar 2022 01:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239629AbiC3FEM (ORCPT ); Wed, 30 Mar 2022 01:04:12 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E826C6819; Tue, 29 Mar 2022 22:02:27 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id ADC4867373; Wed, 30 Mar 2022 07:02:23 +0200 (CEST) Date: Wed, 30 Mar 2022 07:02:23 +0200 From: Christoph Hellwig To: Carlos Llamas Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] loop: fix ioctl calls using compat_loop_info Message-ID: <20220330050223.GA24395@lst.de> References: <20220329201815.1347500-1-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220329201815.1347500-1-cmllamas@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 29, 2022 at 08:18:15PM +0000, Carlos Llamas wrote: > Support for cryptoloop was deleted in commit 47e9624616c8 ("block: > remove support for cryptoloop and the xor transfer"), making the usage > of loop_info->lo_encrypt_type obsolete. However, this member was also > removed from the compat_loop_info definition and this breaks userspace > ioctl calls for 32-bit binaries and CONFIG_COMPAT=y. > > This patch restores the compat_loop_info->lo_encrypt_type member and > marks it obsolete as well as in the uapi header definitions. > > Fixes: 47e9624616c8 ("block: remove support for cryptoloop and the xor transfer") > Signed-off-by: Carlos Llamas Ooops. The fix looks good: Reviewed-by: Christoph Hellwig