* Issues running nvme-tcp/rdma passthru blktests @ 2022-03-31 21:45 Alan Adamson 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson 2022-04-04 16:11 ` Issues running nvme-tcp/rdma passthru blktests Himanshu Madhani 0 siblings, 2 replies; 8+ messages in thread From: Alan Adamson @ 2022-03-31 21:45 UTC (permalink / raw) To: linux-block; +Cc: alan.adamson, linux-nvme, osandov When executing blktest nvme tests with tcp and rdma, and with CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not complete. This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail. The following patch resolves this. Alan ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target 2022-03-31 21:45 Issues running nvme-tcp/rdma passthru blktests Alan Adamson @ 2022-03-31 21:45 ` Alan Adamson 2022-04-02 18:30 ` Sagi Grimberg ` (3 more replies) 2022-04-04 16:11 ` Issues running nvme-tcp/rdma passthru blktests Himanshu Madhani 1 sibling, 4 replies; 8+ messages in thread From: Alan Adamson @ 2022-03-31 21:45 UTC (permalink / raw) To: linux-block; +Cc: alan.adamson, linux-nvme, osandov No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma. Signed-off-by: Alan Adamson <alan.adamson@oracle.com> --- tests/nvme/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/nvme/rc b/tests/nvme/rc index 1c27cdee1b5f..3c38408a0bfe 100644 --- a/tests/nvme/rc +++ b/tests/nvme/rc @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { local subsys_name=$1 _create_nvmet_passthru "${subsys_name}" - port="$(_create_nvmet_port "loop")" + port="$(_create_nvmet_port "${nvme_trtype}")" _add_nvmet_subsys_to_port "${port}" "${subsys_name}" echo "$port" -- 2.27.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson @ 2022-04-02 18:30 ` Sagi Grimberg 2022-04-02 21:39 ` Chaitanya Kulkarni ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Sagi Grimberg @ 2022-04-02 18:30 UTC (permalink / raw) To: Alan Adamson, linux-block; +Cc: linux-nvme, osandov Reviewed-by: Sagi Grimberg <sagi@grimberg.me> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson 2022-04-02 18:30 ` Sagi Grimberg @ 2022-04-02 21:39 ` Chaitanya Kulkarni 2022-04-04 16:13 ` Himanshu Madhani 2022-04-13 15:33 ` Omar Sandoval 3 siblings, 0 replies; 8+ messages in thread From: Chaitanya Kulkarni @ 2022-04-02 21:39 UTC (permalink / raw) To: Alan Adamson Cc: linux-nvme@lists.infradead.org, osandov@fb.com, Logan Gunthorpe, linux-block@vger.kernel.org (+Logan) On 3/31/22 14:45, Alan Adamson wrote: > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- Thanks for your fix, looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson 2022-04-02 18:30 ` Sagi Grimberg 2022-04-02 21:39 ` Chaitanya Kulkarni @ 2022-04-04 16:13 ` Himanshu Madhani 2022-04-13 15:33 ` Omar Sandoval 3 siblings, 0 replies; 8+ messages in thread From: Himanshu Madhani @ 2022-04-04 16:13 UTC (permalink / raw) To: Alan Adamson Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, osandov@fb.com > On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote: > > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- > tests/nvme/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/nvme/rc b/tests/nvme/rc > index 1c27cdee1b5f..3c38408a0bfe 100644 > --- a/tests/nvme/rc > +++ b/tests/nvme/rc > @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { > local subsys_name=$1 > > _create_nvmet_passthru "${subsys_name}" > - port="$(_create_nvmet_port "loop")" > + port="$(_create_nvmet_port "${nvme_trtype}")" > _add_nvmet_subsys_to_port "${port}" "${subsys_name}" > > echo "$port" > -- > 2.27.0 > Looks Good Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson ` (2 preceding siblings ...) 2022-04-04 16:13 ` Himanshu Madhani @ 2022-04-13 15:33 ` Omar Sandoval 3 siblings, 0 replies; 8+ messages in thread From: Omar Sandoval @ 2022-04-13 15:33 UTC (permalink / raw) To: Alan Adamson; +Cc: linux-block, linux-nvme, osandov On Thu, Mar 31, 2022 at 02:45:26PM -0700, Alan Adamson wrote: > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- > tests/nvme/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Issues running nvme-tcp/rdma passthru blktests 2022-03-31 21:45 Issues running nvme-tcp/rdma passthru blktests Alan Adamson 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson @ 2022-04-04 16:11 ` Himanshu Madhani 2022-04-04 16:15 ` Himanshu Madhani 1 sibling, 1 reply; 8+ messages in thread From: Himanshu Madhani @ 2022-04-04 16:11 UTC (permalink / raw) To: Alan Adamson Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, osandov@fb.com > On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote: > > When executing blktest nvme tests with tcp and rdma, and with > CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not > complete. > > This was because the nvme/rc helper for setting up passthru targets > hardcoded trtype to "loop" which resulted in the nvme connect to > fail. > > The following patch resolves this. > > Alan > Can you resend with the patch included? -- Himanshu Madhani Oracle Linux Engineering ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Issues running nvme-tcp/rdma passthru blktests 2022-04-04 16:11 ` Issues running nvme-tcp/rdma passthru blktests Himanshu Madhani @ 2022-04-04 16:15 ` Himanshu Madhani 0 siblings, 0 replies; 8+ messages in thread From: Himanshu Madhani @ 2022-04-04 16:15 UTC (permalink / raw) To: Alan Adamson Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, osandov@fb.com > On Apr 4, 2022, at 9:11 AM, Himanshu Madhani <himanshu.madhani@oracle.com> wrote: > > > >> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote: >> >> When executing blktest nvme tests with tcp and rdma, and with >> CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not >> complete. >> >> This was because the nvme/rc helper for setting up passthru targets >> hardcoded trtype to "loop" which resulted in the nvme connect to >> fail. >> >> The following patch resolves this. >> >> Alan >> > > Can you resend with the patch included? > Ignore this.. patch showed up in my inbox. .. > -- > Himanshu Madhani Oracle Linux Engineering > -- Himanshu Madhani Oracle Linux Engineering ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-13 15:33 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-03-31 21:45 Issues running nvme-tcp/rdma passthru blktests Alan Adamson 2022-03-31 21:45 ` [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target Alan Adamson 2022-04-02 18:30 ` Sagi Grimberg 2022-04-02 21:39 ` Chaitanya Kulkarni 2022-04-04 16:13 ` Himanshu Madhani 2022-04-13 15:33 ` Omar Sandoval 2022-04-04 16:11 ` Issues running nvme-tcp/rdma passthru blktests Himanshu Madhani 2022-04-04 16:15 ` Himanshu Madhani
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).