* [PATCH] block: don't print I/O error warning for dead disks
@ 2022-03-23 16:38 Christoph Hellwig
2022-04-15 4:59 ` Christoph Hellwig
2022-04-15 12:42 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-03-23 16:38 UTC (permalink / raw)
To: axboe; +Cc: linux-block
When a disk has been marked dead, don't print warnings for I/O errors
as they are very much expected.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-mq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 8e659dc5fcf37..5b6a7c9d0d992 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -794,7 +794,8 @@ bool blk_update_request(struct request *req, blk_status_t error,
#endif
if (unlikely(error && !blk_rq_is_passthrough(req) &&
- !(req->rq_flags & RQF_QUIET))) {
+ !(req->rq_flags & RQF_QUIET)) &&
+ !test_bit(GD_DEAD, &req->q->disk->state)) {
blk_print_req_error(req, error);
trace_block_rq_error(req, error, nr_bytes);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] block: don't print I/O error warning for dead disks
2022-03-23 16:38 [PATCH] block: don't print I/O error warning for dead disks Christoph Hellwig
@ 2022-04-15 4:59 ` Christoph Hellwig
2022-04-15 12:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-04-15 4:59 UTC (permalink / raw)
To: axboe; +Cc: linux-block
ping?
On Wed, Mar 23, 2022 at 05:38:15PM +0100, Christoph Hellwig wrote:
> When a disk has been marked dead, don't print warnings for I/O errors
> as they are very much expected.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-mq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 8e659dc5fcf37..5b6a7c9d0d992 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -794,7 +794,8 @@ bool blk_update_request(struct request *req, blk_status_t error,
> #endif
>
> if (unlikely(error && !blk_rq_is_passthrough(req) &&
> - !(req->rq_flags & RQF_QUIET))) {
> + !(req->rq_flags & RQF_QUIET)) &&
> + !test_bit(GD_DEAD, &req->q->disk->state)) {
> blk_print_req_error(req, error);
> trace_block_rq_error(req, error, nr_bytes);
> }
> --
> 2.30.2
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] block: don't print I/O error warning for dead disks
2022-03-23 16:38 [PATCH] block: don't print I/O error warning for dead disks Christoph Hellwig
2022-04-15 4:59 ` Christoph Hellwig
@ 2022-04-15 12:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-04-15 12:42 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-block
On Wed, 23 Mar 2022 17:38:15 +0100, Christoph Hellwig wrote:
> When a disk has been marked dead, don't print warnings for I/O errors
> as they are very much expected.
>
>
Applied, thanks!
[1/1] block: don't print I/O error warning for dead disks
commit: 3d973a76e54c30772e72128ab0552ca75e588893
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-15 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-23 16:38 [PATCH] block: don't print I/O error warning for dead disks Christoph Hellwig
2022-04-15 4:59 ` Christoph Hellwig
2022-04-15 12:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).