Re: [PATCH blktests] block/002: delay debugfs directory check

Ming Lei
2022-04-20T09:34:22Z

On Wed, Apr 20, 2022 at 01:59:11PM +0900, Shin'ichiro Kawasaki wrote:
> The test case block/002 checks that device removal during blktrace run
> does not leak debugfs directory. The Linux kernel commit 0a9a25ca7843
> ("block: let blkcg_gq grab request queue's refcnt") triggered failure of
> the test case. The commit delayed queue release and debugfs directory
> removal then the test case checks directory existence too early. To
> avoid this false-positive failure, delay the directory existence check.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
> tests/block/002 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/block/002 b/tests/block/002
> index 9b183e7..8061c91 100755
> --- a/tests/block/002
> +++ b/tests/block/002
> @@ -29,6 +29,7 @@ test() {
> echo "debugfs directory deleted with blktrace active"
> fi
> { kill $!; wait; } >/dev/null 2>/dev/null
> + sleep 0.5
> if [[ -d /sys/kernel/debug/block/${SCSI_DEBUG_DEVICES[0]} ]]; then
> echo "debugfs directory leaked"
> fi

Hello,

Jens has merged Yu Kuai's fix[1], so I think it won't be triggered now.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=block-5.18&id=a87c29e1a85e64b28445bb1e80505230bf2e3b4b

Thanks,
Ming