From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Mike Snitzer <snitzer@kernel.org>, linux-block@vger.kernel.org
Subject: [PATCH 1/2] block: remove superfluous calls to blkcg_bio_issue_init
Date: Wed, 4 May 2022 07:29:49 -0700 [thread overview]
Message-ID: <20220504142950.567582-2-hch@lst.de> (raw)
In-Reply-To: <20220504142950.567582-1-hch@lst.de>
blkcg_bio_issue_init is called in submit_bio. There is no need to have
extra calls that just get overriden in __bio_clone and the two places
that copy and pasted from it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/bio.c | 1 -
block/blk-crypto-fallback.c | 1 -
block/bounce.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 4259125e16ab2..3cffc01e6377f 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -739,7 +739,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
bio->bi_iter = bio_src->bi_iter;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
if (bio_crypt_clone(bio, bio_src, gfp) < 0)
return -ENOMEM;
diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
index 7c854584b52b5..5ddf33f999dfe 100644
--- a/block/blk-crypto-fallback.c
+++ b/block/blk-crypto-fallback.c
@@ -177,7 +177,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
bio->bi_io_vec[bio->bi_vcnt++] = bv;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
return bio;
}
diff --git a/block/bounce.c b/block/bounce.c
index 467be46d0e656..8f7b6fe3b4db5 100644
--- a/block/bounce.c
+++ b/block/bounce.c
@@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
goto err_put;
bio_clone_blkg_association(bio, bio_src);
- blkcg_bio_issue_init(bio);
return bio;
--
2.30.2
next prev parent reply other threads:[~2022-05-04 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 14:29 bio clone submission micro optimizations Christoph Hellwig
2022-05-04 14:29 ` Christoph Hellwig [this message]
2022-05-04 16:19 ` [PATCH 1/2] block: remove superfluous calls to blkcg_bio_issue_init Mike Snitzer
2022-05-05 0:30 ` Jens Axboe
2022-05-04 14:29 ` [PATCH 2/2] block: allow passing a NULL bdev to bio_alloc_clone/bio_init_clone Christoph Hellwig
2022-05-04 16:20 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504142950.567582-2-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox