From: Christoph Hellwig <hch@lst.de>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Christoph Hellwig <hch@lst.de>,
song@kernel.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] md: remove most calls to bdevname
Date: Thu, 12 May 2022 08:27:27 +0200 [thread overview]
Message-ID: <20220512062727.GA20557@lst.de> (raw)
In-Reply-To: <290eada6-226a-6570-1860-c4ca1d680993@molgen.mpg.de>
On Thu, May 12, 2022 at 08:25:28AM +0200, Paul Menzel wrote:
> Dear Christoph,
>
>
> Thank you for the patch.
>
> Am 12.05.22 um 08:19 schrieb Christoph Hellwig:
>> Use the %pg format specifier to save on stack consuption and code size.
>
> consu*m*ption
>
> Did you do any measurements?
Each BDEVNAME_SIZE array consumes 32 bytes on the stack, and they are
gone now without any additional stack usage elsewhere.
next prev parent reply other threads:[~2022-05-12 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 6:19 [PATCH] md: remove most calls to bdevname Christoph Hellwig
2022-05-12 6:25 ` Paul Menzel
2022-05-12 6:27 ` Christoph Hellwig [this message]
2022-05-12 8:01 ` Paul Menzel
2022-05-12 16:26 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512062727.GA20557@lst.de \
--to=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox