From: "Richard W.M. Jones" <rjones@redhat.com>
To: libguestfs@redhat.com, linux-block@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [Libguestfs] Communication issues between NBD driver and NBDKit server
Date: Sun, 15 May 2022 20:25:05 +0100 [thread overview]
Message-ID: <20220515192505.GJ1127@redhat.com> (raw)
In-Reply-To: <87czgelidg.fsf@vostro.rath.org>
On Sun, May 15, 2022 at 08:12:59PM +0100, Nikolaus Rath wrote:
> Do you see any way for this to happen?
I think it's impossible. A more likely explanation follows.
If you look at the kernel code, the NBD_CMD_INFLIGHT command flag is
cleared when a command times out:
https://github.com/torvalds/linux/blob/0cdd776ec92c0fec768c7079331804d3e52d4b27/drivers/block/nbd.c#L407
That's the place where it would have printed the "Possible stuck
request" message.
Some time later, nbdkit actually replies to the message (for the first
and only time) and in that code the flag is checked and found to be
clear already, causing the "Suspicious reply" message to be printed:
https://github.com/torvalds/linux/blob/0cdd776ec92c0fec768c7079331804d3e52d4b27/drivers/block/nbd.c#L749
I'd say you need to increase the timeout and/or work out why the S3
plugin is taking so long to respond.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2022-05-15 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <04a0a06b-e6dc-48b7-bc29-105dab888a56@www.fastmail.com>
2022-05-15 15:51 ` Communication issues between NBD driver and NBDKit server Josef Bacik
2022-05-15 16:39 ` Nikolaus Rath
2022-05-15 18:05 ` [Libguestfs] " Richard W.M. Jones
2022-05-15 19:12 ` Nikolaus Rath
2022-05-15 19:25 ` Richard W.M. Jones [this message]
2022-05-16 1:08 ` yukuai (C)
2022-05-17 21:16 ` Nikolaus Rath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515192505.GJ1127@redhat.com \
--to=rjones@redhat.com \
--cc=josef@toxicpanda.com \
--cc=libguestfs@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox