From: Christoph Hellwig <hch@lst.de>
To: Khazhy Kumykov <khazhy@google.com>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, w.bumiller@proxmox.com,
cgroups@vger.kernel.org
Subject: Re: Issue with 252c651a4c85 ("blk-cgroup: stop using seq_get_buf")
Date: Tue, 17 May 2022 08:11:52 +0200 [thread overview]
Message-ID: <20220517061152.GA4789@lst.de> (raw)
In-Reply-To: <CACGdZYK3iLc8u+YuyteaWqLRCHUJvR10Gem6MFyx36wP4Z2y2Q@mail.gmail.com>
On Thu, May 12, 2022 at 03:42:54PM -0700, Khazhy Kumykov wrote:
> I can see in the latest tip, if we have devices with no statistics,
> we'll print the maj:min and then nothing else, which can end up
> looking weird, (e.g. like below.) I see that in older kernels, we
> avoided printing the device name at all if there were no stats, and it
> looks like this behavior was silently broken by 252c651a4c85
> ("blk-cgroup: stop using seq_get_buf"), where before we prepared the
> whole line then decided at the end whether to commit it or not.
>
> I do see a patch "blk-cgroup: always terminate io.stat lines" that
> addresses this by just unconditionally printing the newline (though it
> looks like that patch never landed).
It should really go in, I just sent a ping for it.
prev parent reply other threads:[~2022-05-17 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 22:42 Issue with 252c651a4c85 ("blk-cgroup: stop using seq_get_buf") Khazhy Kumykov
2022-05-12 23:25 ` Khazhy Kumykov
2022-05-12 23:29 ` [RFC PATCH] blkcg: rewind seq_file if no stats Khazhismel Kumykov
2022-05-13 16:30 ` Tejun Heo
2022-05-13 17:40 ` [RESEND][RFC " Khazhismel Kumykov
2022-05-13 18:06 ` Khazhy Kumykov
2022-05-17 6:12 ` Christoph Hellwig
2022-05-17 6:27 ` Khazhy Kumykov
2022-05-17 6:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517061152.GA4789@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox