From: Keith Busch <kbusch@fb.com>
To: <linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>
Cc: <axboe@kernel.dk>, Kernel Team <Kernel-team@fb.com>, <hch@lst.de>,
<bvanassche@acm.org>, <damien.lemoal@opensource.wdc.com>,
<ebiggers@kernel.org>, Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3 2/6] block: export dma_alignment attribute
Date: Mon, 23 May 2022 14:01:15 -0700 [thread overview]
Message-ID: <20220523210119.2500150-3-kbusch@fb.com> (raw)
In-Reply-To: <20220523210119.2500150-1-kbusch@fb.com>
From: Keith Busch <kbusch@kernel.org>
User space may want to know how to align their buffers to avoid
bouncing. Export the queue attribute.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
v2->v3:
Added Documentation (Bart)
Documentation/ABI/stable/sysfs-block | 9 +++++++++
block/blk-sysfs.c | 7 +++++++
2 files changed, 16 insertions(+)
diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
index e8797cd09aff..08f6d00df138 100644
--- a/Documentation/ABI/stable/sysfs-block
+++ b/Documentation/ABI/stable/sysfs-block
@@ -142,6 +142,15 @@ Description:
Default value of this file is '1'(on).
+What: /sys/block/<disk>/queue/dma_alignment
+Date: May 2022
+Contact: linux-block@vger.kernel.org
+Description:
+ Reports the alignment that user space addresses must have to be
+ used for raw block device access with O_DIRECT and other driver
+ specific passthrough mechanisms.
+
+
What: /sys/block/<disk>/queue/chunk_sectors
Date: September 2016
Contact: Hannes Reinecke <hare@suse.com>
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 88bd41d4cb59..14607565d781 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -274,6 +274,11 @@ static ssize_t queue_virt_boundary_mask_show(struct request_queue *q, char *page
return queue_var_show(q->limits.virt_boundary_mask, page);
}
+static ssize_t queue_dma_alignment_show(struct request_queue *q, char *page)
+{
+ return queue_var_show(queue_dma_alignment(q), page);
+}
+
#define QUEUE_SYSFS_BIT_FNS(name, flag, neg) \
static ssize_t \
queue_##name##_show(struct request_queue *q, char *page) \
@@ -606,6 +611,7 @@ QUEUE_RO_ENTRY(queue_dax, "dax");
QUEUE_RW_ENTRY(queue_io_timeout, "io_timeout");
QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec");
QUEUE_RO_ENTRY(queue_virt_boundary_mask, "virt_boundary_mask");
+QUEUE_RO_ENTRY(queue_dma_alignment, "dma_alignment");
#ifdef CONFIG_BLK_DEV_THROTTLING_LOW
QUEUE_RW_ENTRY(blk_throtl_sample_time, "throttle_sample_time");
@@ -667,6 +673,7 @@ static struct attribute *queue_attrs[] = {
&blk_throtl_sample_time_entry.attr,
#endif
&queue_virt_boundary_mask_entry.attr,
+ &queue_dma_alignment_entry.attr,
NULL,
};
--
2.30.2
next prev parent reply other threads:[~2022-05-23 21:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 21:01 [PATCHv3 0/6] direct io dma alignment Keith Busch
2022-05-23 21:01 ` [PATCHv3 1/6] block/bio: remove duplicate append pages code Keith Busch
2022-05-24 6:00 ` Christoph Hellwig
2022-05-24 6:24 ` Johannes Thumshirn
2022-05-24 14:17 ` Pankaj Raghav
2022-05-24 15:38 ` Keith Busch
2022-05-25 7:49 ` Pankaj Raghav
2022-05-25 8:30 ` Damien Le Moal
2022-05-25 13:37 ` Keith Busch
2022-05-25 14:25 ` Pankaj Raghav
2022-05-23 21:01 ` Keith Busch [this message]
2022-05-24 6:02 ` [PATCHv3 2/6] block: export dma_alignment attribute Christoph Hellwig
2022-05-24 6:24 ` Johannes Thumshirn
2022-05-23 21:01 ` [PATCHv3 3/6] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-24 6:02 ` Christoph Hellwig
2022-05-24 6:25 ` Johannes Thumshirn
2022-05-23 21:01 ` [PATCHv3 4/6] block/merge: count bytes instead of sectors Keith Busch
2022-05-24 6:07 ` Christoph Hellwig
2022-05-23 21:01 ` [PATCHv3 5/6] block/bounce: " Keith Busch
2022-05-24 6:09 ` Christoph Hellwig
2022-05-25 14:08 ` Keith Busch
2022-05-25 14:17 ` Keith Busch
2022-05-24 14:32 ` Pankaj Raghav
2022-05-23 21:01 ` [PATCHv3 6/6] block: relax direct io memory alignment Keith Busch
2022-05-24 6:12 ` Christoph Hellwig
2022-05-24 15:19 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523210119.2500150-3-kbusch@fb.com \
--to=kbusch@fb.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox