From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, shinichiro.kawasaki@wdc.com,
dan.j.williams@intel.com, yukuai3@huawei.com,
ming.lei@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: remove per-disk debugfs files in blk_unregister_queue
Date: Tue, 24 May 2022 14:00:06 +0200 [thread overview]
Message-ID: <20220524120006.GA17563@lst.de> (raw)
In-Reply-To: <9f988597-77b7-de53-79f4-ed2e70a0eaab@suse.de>
On Tue, May 24, 2022 at 11:29:05AM +0200, Hannes Reinecke wrote:
> Calling debugfs_remove_recursive(q->debugfs_dir) for all queue types, but
> setting q->debugfs_dir to NULL only for mq?
> Care to explain?
->debugfs_dir is never set to NULL, only q->sched_debugfs_dir and
q->rqos_debugfs_dir. Both of those are only used for blk-mq (and
don't really need the reset either, but this is all existing code
and will be dealt with later instead of a minimalistic bug fix.
next prev parent reply other threads:[~2022-05-24 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 8:33 [PATCH] block: remove per-disk debugfs files in blk_unregister_queue Christoph Hellwig
2022-05-24 9:29 ` Hannes Reinecke
2022-05-24 12:00 ` Christoph Hellwig [this message]
2022-05-24 11:47 ` Ming Lei
2022-05-24 12:01 ` Christoph Hellwig
2022-05-24 12:14 ` Ming Lei
2022-05-24 13:06 ` Christoph Hellwig
2022-05-24 14:44 ` Ming Lei
2022-05-27 7:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524120006.GA17563@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).