From: Pankaj Raghav <pankydev8@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, Kernel Team <Kernel-team@fb.com>,
hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com,
ebiggers@kernel.org, Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCHv3 1/6] block/bio: remove duplicate append pages code
Date: Wed, 25 May 2022 09:49:41 +0200 [thread overview]
Message-ID: <20220525074941.2biavbbrjdjcnlsd@quentin> (raw)
In-Reply-To: <Yoz7+O2CAQTNfvlV@kbusch-mbp.dhcp.thefacebook.com>
On Tue, May 24, 2022 at 09:38:32AM -0600, Keith Busch wrote:
> On Tue, May 24, 2022 at 04:17:54PM +0200, Pankaj Raghav wrote:
> > On Mon, May 23, 2022 at 02:01:14PM -0700, Keith Busch wrote:
> > > - if (WARN_ON_ONCE(!max_append_sectors))
> > > - return 0;
> > I don't see this check in the append path. Should it be added in
> > bio_iov_add_zone_append_page() function?
>
> I'm not sure this check makes a lot of sense. If it just returns 0 here, then
> won't that get bio_iov_iter_get_pages() stuck in an infinite loop? The bio
> isn't filling, the iov isn't advancing, and 0 indicates keep-going.
Yeah but if max_append_sectors is zero, then bio_add_hw_page() also
returns 0 as follows:
....
if (((bio->bi_iter.bi_size + len) >> 9) > max_sectors)
return 0;
....
With WARN_ON_ONCE, we at least get a warning message if it gets stuck in an
infinite loop because of max_append_sectors being zero right?
--
Pankaj Raghav
next prev parent reply other threads:[~2022-05-25 7:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 21:01 [PATCHv3 0/6] direct io dma alignment Keith Busch
2022-05-23 21:01 ` [PATCHv3 1/6] block/bio: remove duplicate append pages code Keith Busch
2022-05-24 6:00 ` Christoph Hellwig
2022-05-24 6:24 ` Johannes Thumshirn
2022-05-24 14:17 ` Pankaj Raghav
2022-05-24 15:38 ` Keith Busch
2022-05-25 7:49 ` Pankaj Raghav [this message]
2022-05-25 8:30 ` Damien Le Moal
2022-05-25 13:37 ` Keith Busch
2022-05-25 14:25 ` Pankaj Raghav
2022-05-23 21:01 ` [PATCHv3 2/6] block: export dma_alignment attribute Keith Busch
2022-05-24 6:02 ` Christoph Hellwig
2022-05-24 6:24 ` Johannes Thumshirn
2022-05-23 21:01 ` [PATCHv3 3/6] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-24 6:02 ` Christoph Hellwig
2022-05-24 6:25 ` Johannes Thumshirn
2022-05-23 21:01 ` [PATCHv3 4/6] block/merge: count bytes instead of sectors Keith Busch
2022-05-24 6:07 ` Christoph Hellwig
2022-05-23 21:01 ` [PATCHv3 5/6] block/bounce: " Keith Busch
2022-05-24 6:09 ` Christoph Hellwig
2022-05-25 14:08 ` Keith Busch
2022-05-25 14:17 ` Keith Busch
2022-05-24 14:32 ` Pankaj Raghav
2022-05-23 21:01 ` [PATCHv3 6/6] block: relax direct io memory alignment Keith Busch
2022-05-24 6:12 ` Christoph Hellwig
2022-05-24 15:19 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525074941.2biavbbrjdjcnlsd@quentin \
--to=pankydev8@gmail.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox