From: Keith Busch <kbusch@fb.com>
To: <linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>
Cc: <axboe@kernel.dk>, Kernel Team <Kernel-team@fb.com>, <hch@lst.de>,
<bvanassche@acm.org>, <damien.lemoal@opensource.wdc.com>,
<ebiggers@kernel.org>, <pankydev8@gmail.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv4 9/9] fs: add support for dma aligned direct-io
Date: Wed, 25 May 2022 18:06:13 -0700 [thread overview]
Message-ID: <20220526010613.4016118-10-kbusch@fb.com> (raw)
In-Reply-To: <20220526010613.4016118-1-kbusch@fb.com>
From: Keith Busch <kbusch@kernel.org>
Use the address alignment requirements from the hardware for direct io
instead of requiring addresses be aligned to the block size.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
fs/direct-io.c | 11 +++++++----
fs/iomap/direct-io.c | 3 ++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 840752006f60..64cc176be60c 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1131,7 +1131,7 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
struct dio_submit sdio = { 0, };
struct buffer_head map_bh = { 0, };
struct blk_plug plug;
- unsigned long align = offset | iov_iter_alignment(iter);
+ unsigned long align = iov_iter_alignment(iter);
/*
* Avoid references to bdev if not absolutely needed to give
@@ -1165,11 +1165,14 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
goto fail_dio;
}
- if (align & blocksize_mask) {
- if (bdev)
+ if ((offset | align) & blocksize_mask) {
+ if (bdev) {
blkbits = blksize_bits(bdev_logical_block_size(bdev));
+ if (align & bdev_dma_alignment(bdev))
+ goto fail_dio;
+ }
blocksize_mask = (1 << blkbits) - 1;
- if (align & blocksize_mask)
+ if ((offset | count) & blocksize_mask)
goto fail_dio;
}
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 80f9b047aa1b..0256d28baa8e 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -244,7 +244,8 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
size_t copied = 0;
size_t orig_count;
- if ((pos | length | align) & ((1 << blkbits) - 1))
+ if ((pos | length) & ((1 << blkbits) - 1) ||
+ align & bdev_dma_alignment(iomap->bdev))
return -EINVAL;
if (iomap->type == IOMAP_UNWRITTEN) {
--
2.30.2
next prev parent reply other threads:[~2022-05-26 1:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:06 [PATCHv4 0/9] direct io dma alignment Keith Busch
2022-05-26 1:06 ` [PATCHv4 1/9] block: fix infiniate loop for invalid zone append Keith Busch
2022-05-26 1:48 ` Damien Le Moal
2022-05-31 6:19 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 2/9] block/bio: remove duplicate append pages code Keith Busch
2022-05-26 1:06 ` [PATCHv4 3/9] block: export dma_alignment attribute Keith Busch
2022-05-26 7:30 ` Eric Biggers
2022-05-26 1:06 ` [PATCHv4 4/9] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-26 1:06 ` [PATCHv4 5/9] block: add a helper function for dio alignment Keith Busch
2022-05-26 1:54 ` Damien Le Moal
2022-05-31 6:22 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 6/9] block/merge: count bytes instead of sectors Keith Busch
2022-05-26 1:57 ` Damien Le Moal
2022-05-31 6:25 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 7/9] block/bounce: " Keith Busch
2022-05-26 1:58 ` Damien Le Moal
2022-05-30 15:08 ` Pankaj Raghav
2022-05-31 6:26 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 8/9] block: relax direct io memory alignment Keith Busch
2022-05-26 2:03 ` Damien Le Moal
2022-05-26 7:29 ` Eric Biggers
2022-05-26 13:50 ` Keith Busch
2022-05-26 18:13 ` Eric Biggers
2022-05-26 18:55 ` Keith Busch
2022-05-26 20:32 ` Keith Busch
2022-05-31 6:30 ` Christoph Hellwig
2022-05-26 1:06 ` Keith Busch [this message]
2022-05-26 2:01 ` [PATCHv4 9/9] fs: add support for dma aligned direct-io Damien Le Moal
2022-05-31 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526010613.4016118-10-kbusch@fb.com \
--to=kbusch@fb.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox