Re: [PATCHv4 6/9] block/merge: count bytes instead of sectors

Christoph Hellwig
2022-05-31T06:26:02Z

On Wed, May 25, 2022 at 06:06:10PM -0700, Keith Busch wrote:
> + /*
> + * Individual bvecs may not be logical block aligned, so round down to
> + * that size to ensure both sides of the split bio are appropriately
> + * sized.
> + */

Maybe I'd word this as:

/*
* Individual bvecs may not be logical block aligned. Round down
* the split size so that each bio is properly sector size aligned,
* even if we do not use the full hardware limits.
*/

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>