From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09822C433EF for ; Thu, 26 May 2022 09:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346772AbiEZJIH (ORCPT ); Thu, 26 May 2022 05:08:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241430AbiEZJIG (ORCPT ); Thu, 26 May 2022 05:08:06 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BB8E13F0F; Thu, 26 May 2022 02:08:05 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 9B6BD68B05; Thu, 26 May 2022 11:08:01 +0200 (CEST) Date: Thu, 26 May 2022 11:08:01 +0200 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , Ulf Hansson , linux-block@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 11/14] block: remove GENHD_FL_EXT_DEVT Message-ID: <20220526090801.GA27200@lst.de> References: <20211122130625.1136848-1-hch@lst.de> <20211122130625.1136848-12-hch@lst.de> <20220525165114.GA2750@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 26, 2022 at 11:06:47AM +0800, Ming Lei wrote: > BTW, SUPPRESS_PART_SCAN looks more like one flag, instead of 'state'. It is kinda inbetween, but I favour the state. ->flags is suppoed to be set statically at initialization time, and the GENHD_FL_NO_PART usage by loop is the only thing that violates it. And once a device declares support for partitions supresing the scans is basically a policy and thus a state anyway.