public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	Coly Li <colyli@suse.de>
Subject: [PATCH 0/1] bcache fix for Linux v5.19 (3rd wave)
Date: Sat, 28 May 2022 14:19:48 +0800	[thread overview]
Message-ID: <20220528061949.28519-1-colyli@suse.de> (raw)

Hi Jens,

This submission only has 1 patch, which is the effort to avoid bogus
soft lockup warning from the bcache writeback rate update kworker.

Based on your suggestion, this version is more clear and simple, it
works as expected in my testing. BCH_WBRATE_UPDATE_RETRY_MAX (15)
defines the maximum retry times for lock contention, in worst case it
is 1+ minutes before update_writeback_rate() call down_read() to acquire
dc->writeback_lock.

Please consider to take it, and thank you again for the suggestion.

Coly Li
---

Coly Li (1):
  bcache: avoid unnecessary soft lockup in kworker
    update_writeback_rate()

 drivers/md/bcache/bcache.h    |  7 +++++++
 drivers/md/bcache/writeback.c | 31 +++++++++++++++++++++----------
 2 files changed, 28 insertions(+), 10 deletions(-)

-- 
2.35.3


             reply	other threads:[~2022-05-28  6:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28  6:19 Coly Li [this message]
2022-05-28  6:19 ` [PATCH 1/1] bcache: avoid unnecessary soft lockup in kworker update_writeback_rate() Coly Li
2022-05-28 12:20   ` Jens Axboe
2022-05-28 12:22     ` Coly Li
2022-05-28 12:23       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220528061949.28519-1-colyli@suse.de \
    --to=colyli@suse.de \
    --cc=axboe@kernel.dk \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox