Re: [PATCH blktests 13/13] zbd: allow falling back to builtin null_blk

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

The word "builtin" in the commit title would be "built-in".

On Jun 03, 2022 / 06:55, Christoph Hellwig wrote:
> Use _configure_null_blk to configure the fallback device and thus allow
> for a built-in null_blk driver.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/zbd/rc | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/zbd/rc b/tests/zbd/rc
> index 9deadc1..e56d607 100644
> --- a/tests/zbd/rc
> +++ b/tests/zbd/rc
> @@ -13,7 +13,7 @@
>  
>  group_requires() {
>  	_have_root && _have_program blkzone && _have_program dd &&
> -		_have_kernel_option BLK_DEV_ZONED && _have_modules null_blk &&
> +		_have_kernel_option BLK_DEV_ZONED && _have_null_blk &&
>  		_have_module_param null_blk zoned
>  }
>  
> @@ -25,10 +25,11 @@ group_device_requires() {
>  }
>  
>  _fallback_null_blk_zoned() {
> -	if ! _init_null_blk zone_size=4 gb=1 zoned=1 ; then
> +	if ! _configure_null_blk nullb1 zone_size=4 size=1048576 zoned=1 \

The unit of null_blk sysfs size attribute is MB. 1048576 MB = 1 TB null_blk
is too big and triggers failure of zbd/006. The value should be size=1024 to
keep the same size 1 GB as before.

> +			power=1; then
>  		return 1
>  	fi
> -	echo /dev/nullb0
> +	echo /dev/nullb1
>  }
>  
>  #
> -- 
> 2.30.2
> 

-- 
Shin'ichiro Kawasaki