Re: [PATCH v2 16/19] hugetlb: Convert to migrate_folio

Mike Kravetz
2022-06-09T20:52:06Z

On 6/8/22 08:02, Matthew Wilcox (Oracle) wrote:
> This involves converting migrate_huge_page_move_mapping(). We also need a
> folio variant of hugetlb_set_page_subpool(), but that's for a later patch.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> fs/hugetlbfs/inode.c | 23 ++++++++++++++---------
> include/linux/migrate.h | 6 +++---
> mm/migrate.c | 18 +++++++++---------
> 3 files changed, 26 insertions(+), 21 deletions(-)
>

Thanks,

> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 14d33f725e05..eca1d0fabd7e 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -954,28 +954,33 @@ static int hugetlbfs_symlink(struct user_namespace *mnt_userns,
> return error;
> }
>
> -static int hugetlbfs_migrate_page(struct address_space *mapping,
> - struct page *newpage, struct page *page,
> +#ifdef CONFIG_MIGRATION

and, thanks for adding the #ifdef CONFIG_MIGRATION to save a little space.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

--
Mike Kravetz