Re: [PATCH v2 01/19] secretmem: Remove isolate_page

David Hildenbrand
2022-06-09T12:46:22Z

On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote:
> The isolate_page operation is never called for filesystems, only
> for device drivers which call SetPageMovable.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/secretmem.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 206ed6b40c1d..1c7f1775b56e 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -133,11 +133,6 @@ static const struct file_operations secretmem_fops = {
> .mmap = secretmem_mmap,
> };
>
> -static bool secretmem_isolate_page(struct page *page, isolate_mode_t mode)
> -{
> - return false;
> -}
> -
> static int secretmem_migratepage(struct address_space *mapping,
> struct page *newpage, struct page *page,
> enum migrate_mode mode)
> @@ -155,7 +150,6 @@ const struct address_space_operations secretmem_aops = {
> .dirty_folio = noop_dirty_folio,
> .free_folio = secretmem_free_folio,
> .migratepage = secretmem_migratepage,
> - .isolate_page = secretmem_isolate_page,
> };
>
> static int secretmem_setattr(struct user_namespace *mnt_userns,

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb