Re: [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations

David Hildenbrand
2022-06-09T10:24:13Z

On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote:
> These drivers are rather uncomfortably hammered into the
> address_space_operations hole. They aren't filesystems and don't behave
> like filesystems. They just need their own movable_operations structure,
> which we can point to directly from page->mapping.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> arch/powerpc/platforms/pseries/cmm.c | 60 +---------------
> drivers/misc/vmw_balloon.c | 61 +---------------
> drivers/virtio/virtio_balloon.c | 47 +-----------
> include/linux/balloon_compaction.h | 6 +-
> include/linux/fs.h | 2 -
> include/linux/migrate.h | 26 +++++--
> include/linux/page-flags.h | 2 +-
> include/uapi/linux/magic.h | 4 --
> mm/balloon_compaction.c | 10 ++-
> mm/compaction.c | 29 ++++----
> mm/migrate.c | 24 +++----
> mm/util.c | 4 +-
> mm/z3fold.c | 82 +++------------------
> mm/zsmalloc.c | 102 ++++++---------------------
> 14 files changed, 94 insertions(+), 365 deletions(-)

You probably should have cc'ed the relevant maintainers (including me :P ).

For everything except z3fold.c and zsmalloc.c,

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb