From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Khazhy Kumykov <khazhy@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH 1/5] block: Introduce the blk_rq_is_seq_write() function
Date: Tue, 14 Jun 2022 10:49:39 -0700 [thread overview]
Message-ID: <20220614174943.611369-2-bvanassche@acm.org> (raw)
In-Reply-To: <20220614174943.611369-1-bvanassche@acm.org>
Introduce a function that makes it easy to verify whether a write
request is for a sequential write required or sequential write preferred
zone.
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
include/linux/blk-mq.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index e2d9daf7e8dd..3e7feb48105f 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -1129,6 +1129,15 @@ static inline unsigned int blk_rq_zone_is_seq(struct request *rq)
return blk_queue_zone_is_seq(rq->q, blk_rq_pos(rq));
}
+/**
+ * blk_rq_is_seq_write() - Whether @rq is a write request for a sequential zone.
+ * @rq: Request to examine.
+ */
+static inline bool blk_rq_is_seq_write(struct request *rq)
+{
+ return req_op(rq) == REQ_OP_WRITE && blk_rq_zone_is_seq(rq);
+}
+
bool blk_req_needs_zone_write_lock(struct request *rq);
bool blk_req_zone_write_trylock(struct request *rq);
void __blk_req_zone_write_lock(struct request *rq);
@@ -1159,6 +1168,11 @@ static inline bool blk_req_can_dispatch_to_zone(struct request *rq)
return !blk_req_zone_is_write_locked(rq);
}
#else /* CONFIG_BLK_DEV_ZONED */
+static inline bool blk_rq_is_seq_write(struct request *rq)
+{
+ return false;
+}
+
static inline bool blk_req_needs_zone_write_lock(struct request *rq)
{
return false;
next prev parent reply other threads:[~2022-06-14 17:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 17:49 [PATCH 0/5] Improve zoned storage write performance Bart Van Assche
2022-06-14 17:49 ` Bart Van Assche [this message]
2022-06-16 20:41 ` [PATCH 1/5] block: Introduce the blk_rq_is_seq_write() function Jens Axboe
2022-06-16 21:16 ` Bart Van Assche
2022-06-14 17:49 ` [PATCH 2/5] scsi: Retry unaligned zoned writes Bart Van Assche
2022-06-14 21:47 ` Khazhy Kumykov
2022-06-14 22:39 ` Bart Van Assche
2022-06-14 23:50 ` Damien Le Moal
2022-06-14 23:54 ` Bart Van Assche
2022-06-15 0:55 ` Damien Le Moal
2022-06-14 23:29 ` Damien Le Moal
2022-06-14 23:56 ` Bart Van Assche
2022-06-15 1:09 ` Damien Le Moal
2022-06-15 5:49 ` Christoph Hellwig
2022-06-15 7:21 ` Damien Le Moal
2022-06-15 19:38 ` Bart Van Assche
2022-06-16 0:14 ` Damien Le Moal
2022-06-15 19:42 ` Bart Van Assche
2022-06-16 18:36 ` Bart Van Assche
2022-06-14 17:49 ` [PATCH 3/5] nvme: Make the number of retries request specific Bart Van Assche
2022-06-14 17:49 ` [PATCH 4/5] nvme: Increase the number of retries for zoned writes Bart Van Assche
2022-06-14 18:03 ` Keith Busch
2022-06-14 17:49 ` [PATCH 5/5] block/mq-deadline: Remove zone locking Bart Van Assche
2022-06-14 23:40 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614174943.611369-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).