From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Khazhy Kumykov <khazhy@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH 3/5] nvme: Make the number of retries request specific
Date: Tue, 14 Jun 2022 10:49:41 -0700 [thread overview]
Message-ID: <20220614174943.611369-4-bvanassche@acm.org> (raw)
In-Reply-To: <20220614174943.611369-1-bvanassche@acm.org>
Add support for specifying the number of retries per NVMe request.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/nvme/host/core.c | 3 ++-
drivers/nvme/host/nvme.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 24165daee3c8..fe0d09fc70ba 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -339,7 +339,7 @@ static inline enum nvme_disposition nvme_decide_disposition(struct request *req)
if (blk_noretry_request(req) ||
(nvme_req(req)->status & NVME_SC_DNR) ||
- nvme_req(req)->retries >= nvme_max_retries)
+ nvme_req(req)->retries >= nvme_req(req)->max_retries)
return COMPLETE;
if (req->cmd_flags & REQ_NVME_MPATH) {
@@ -632,6 +632,7 @@ static inline void nvme_clear_nvme_request(struct request *req)
{
nvme_req(req)->status = 0;
nvme_req(req)->retries = 0;
+ nvme_req(req)->max_retries = nvme_max_retries;
nvme_req(req)->flags = 0;
req->rq_flags |= RQF_DONTPREP;
}
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 9b72b6ecf33c..15bb36923d09 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -160,6 +160,7 @@ struct nvme_request {
union nvme_result result;
u8 genctr;
u8 retries;
+ u8 max_retries;
u8 flags;
u16 status;
struct nvme_ctrl *ctrl;
next prev parent reply other threads:[~2022-06-14 17:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 17:49 [PATCH 0/5] Improve zoned storage write performance Bart Van Assche
2022-06-14 17:49 ` [PATCH 1/5] block: Introduce the blk_rq_is_seq_write() function Bart Van Assche
2022-06-16 20:41 ` Jens Axboe
2022-06-16 21:16 ` Bart Van Assche
2022-06-14 17:49 ` [PATCH 2/5] scsi: Retry unaligned zoned writes Bart Van Assche
2022-06-14 21:47 ` Khazhy Kumykov
2022-06-14 22:39 ` Bart Van Assche
2022-06-14 23:50 ` Damien Le Moal
2022-06-14 23:54 ` Bart Van Assche
2022-06-15 0:55 ` Damien Le Moal
2022-06-14 23:29 ` Damien Le Moal
2022-06-14 23:56 ` Bart Van Assche
2022-06-15 1:09 ` Damien Le Moal
2022-06-15 5:49 ` Christoph Hellwig
2022-06-15 7:21 ` Damien Le Moal
2022-06-15 19:38 ` Bart Van Assche
2022-06-16 0:14 ` Damien Le Moal
2022-06-15 19:42 ` Bart Van Assche
2022-06-16 18:36 ` Bart Van Assche
2022-06-14 17:49 ` Bart Van Assche [this message]
2022-06-14 17:49 ` [PATCH 4/5] nvme: Increase the number of retries for " Bart Van Assche
2022-06-14 18:03 ` Keith Busch
2022-06-14 17:49 ` [PATCH 5/5] block/mq-deadline: Remove zone locking Bart Van Assche
2022-06-14 23:40 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614174943.611369-4-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).