Re: blktests failures with v5.19-rc1

Keith Busch
2022-06-10T14:48:49Z

On Fri, Jun 10, 2022 at 12:25:17PM +0000, Shinichiro Kawasaki wrote:
> On Jun 10, 2022 / 09:32, Chaitanya Kulkarni wrote:
> > >> #6: nvme/032: Failed at the first run after system reboot.
> > >> Used QEMU NVME device as TEST_DEV.
> > >>
> >
> > ofcourse we need to fix this issue but can you also
> > try it with the real H/W ?
>
> Hi Chaitanya, thank you for looking into the failures. I have just run the test
> case nvme/032 with real NVME device and observed the exactly same symptom as
> QEMU NVME device.

QEMU is perfectly fine for this test. There's no need to bring in "real"
hardware for this.

And I am not even sure this is real. I don't know yet why this is showing up
only now, but this should fix it:

---
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index fc804e08e3cb..bebd816c11e6 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -476,7 +476,7 @@ static ssize_t dev_rescan_store(struct device *dev,
}
return count;
}
-static struct device_attribute dev_attr_dev_rescan = __ATTR(rescan, 0200, NULL,
+static struct device_attribute dev_attr_dev_rescan = __ATTR_IGNORE_LOCKDEP(rescan, 0200, NULL,
dev_rescan_store);

static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
--