From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 3/6] block: remove QUEUE_FLAG_DEAD
Date: Mon, 20 Jun 2022 08:20:11 +0200 [thread overview]
Message-ID: <20220620062011.GA10640@lst.de> (raw)
In-Reply-To: <463adfd1-45fb-0f9f-2f25-34408b76e75c@acm.org>
On Sun, Jun 19, 2022 at 07:07:20AM -0700, Bart Van Assche wrote:
>> - if (blk_queue_dead(q))
>> + if (blk_queue_dying(q))
>> return -ENOENT;
>
> I'm missing an explanation of why this patch forbids triggering a queue run
> in the dying state. "dying" means that allocation of new requests will
> fail. Unless if something fundamentally has changed in the block layer it
> should still be safe to trigger a queue run in the "dying" state.
It is safe, but not worth having another queue state for given that we
can otherwise remove the QUEUE_FLAG_DEAD bit.
next prev parent reply other threads:[~2022-06-20 6:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 6:05 fully tear down the queue in del_gendisk Christoph Hellwig
2022-06-19 6:05 ` [PATCH 1/6] mtip32xx: remove the device_status debugfs file Christoph Hellwig
2022-06-20 8:37 ` Hannes Reinecke
2022-06-19 6:05 ` [PATCH 2/6] mtip32xx: fix device removal Christoph Hellwig
2022-06-20 8:38 ` Hannes Reinecke
2022-06-19 6:05 ` [PATCH 3/6] block: remove QUEUE_FLAG_DEAD Christoph Hellwig
2022-06-19 14:07 ` Bart Van Assche
2022-06-20 6:20 ` Christoph Hellwig [this message]
2022-06-20 8:39 ` Hannes Reinecke
2022-06-19 6:05 ` [PATCH 4/6] block: stop setting the nomerges flags in blk_cleanup_queue Christoph Hellwig
2022-06-20 8:40 ` Hannes Reinecke
2022-06-19 6:05 ` [PATCH 5/6] block: simplify disk shutdown Christoph Hellwig
2022-06-20 8:47 ` Hannes Reinecke
2022-06-19 6:05 ` [PATCH 6/6] block: remove blk_cleanup_disk Christoph Hellwig
2022-06-20 8:49 ` Hannes Reinecke
2022-06-20 8:56 ` Christoph Hellwig
2022-06-20 9:00 ` Hannes Reinecke
2022-06-28 14:42 ` Sagi Grimberg
2022-06-19 22:21 ` fully tear down the queue in del_gendisk Jens Axboe
2022-06-20 6:09 ` Christoph Hellwig
2022-06-20 11:16 ` Jens Axboe
2022-06-28 5:11 ` Christoph Hellwig
2022-06-28 12:29 ` Jens Axboe
2022-06-28 12:35 ` Jens Axboe
2022-06-28 12:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620062011.GA10640@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox