linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: linux-block@vger.kernel.org
Cc: shinichiro.kawasaki@wdc.com, yangx.jy@fujitsu.com
Subject: [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma
Date: Thu, 30 Jun 2022 17:56:25 +0800	[thread overview]
Message-ID: <20220630095625.2705173-1-yi.zhang@redhat.com> (raw)

The rxe/siw driver will be bind to NO-CARRIER interface which lead
nvmeof-mp/001 failed.
For example, nvmeof-mp/001 with two NICs, if will output
count_devices(): 1 <> 2 when the second NIC has NO-CARRIER

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 common/multipath-over-rdma | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
index 8edcf39..8ab3da1 100644
--- a/common/multipath-over-rdma
+++ b/common/multipath-over-rdma
@@ -409,6 +409,7 @@ start_soft_rdma() {
 				[ -e "$i" ] || continue
 				[ "$i" = "lo" ] && continue
 				[ "$(<"$i/addr_len")" = 6 ] || continue
+				[ "$(<"$i/carrier")" = 1 ] || continue
 				has_soft_rdma "$i" && continue
 				rdma link add "${i}_$type" type $type netdev "$i" ||
 				echo "Failed to bind the $type driver to $i"
-- 
2.34.1


             reply	other threads:[~2022-06-30  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  9:56 Yi Zhang [this message]
2022-06-30 15:43 ` [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma Bart Van Assche
2022-07-01 13:46 ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630095625.2705173-1-yi.zhang@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=yangx.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).