* [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma
@ 2022-06-30 9:56 Yi Zhang
2022-06-30 15:43 ` Bart Van Assche
2022-07-01 13:46 ` Shinichiro Kawasaki
0 siblings, 2 replies; 3+ messages in thread
From: Yi Zhang @ 2022-06-30 9:56 UTC (permalink / raw)
To: linux-block; +Cc: shinichiro.kawasaki, yangx.jy
The rxe/siw driver will be bind to NO-CARRIER interface which lead
nvmeof-mp/001 failed.
For example, nvmeof-mp/001 with two NICs, if will output
count_devices(): 1 <> 2 when the second NIC has NO-CARRIER
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
common/multipath-over-rdma | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
index 8edcf39..8ab3da1 100644
--- a/common/multipath-over-rdma
+++ b/common/multipath-over-rdma
@@ -409,6 +409,7 @@ start_soft_rdma() {
[ -e "$i" ] || continue
[ "$i" = "lo" ] && continue
[ "$(<"$i/addr_len")" = 6 ] || continue
+ [ "$(<"$i/carrier")" = 1 ] || continue
has_soft_rdma "$i" && continue
rdma link add "${i}_$type" type $type netdev "$i" ||
echo "Failed to bind the $type driver to $i"
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma
2022-06-30 9:56 [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma Yi Zhang
@ 2022-06-30 15:43 ` Bart Van Assche
2022-07-01 13:46 ` Shinichiro Kawasaki
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2022-06-30 15:43 UTC (permalink / raw)
To: Yi Zhang, linux-block; +Cc: shinichiro.kawasaki, yangx.jy
On 6/30/22 02:56, Yi Zhang wrote:
> The rxe/siw driver will be bind to NO-CARRIER interface which lead
> nvmeof-mp/001 failed.
> For example, nvmeof-mp/001 with two NICs, if will output
> count_devices(): 1 <> 2 when the second NIC has NO-CARRIER
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma
2022-06-30 9:56 [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma Yi Zhang
2022-06-30 15:43 ` Bart Van Assche
@ 2022-07-01 13:46 ` Shinichiro Kawasaki
1 sibling, 0 replies; 3+ messages in thread
From: Shinichiro Kawasaki @ 2022-07-01 13:46 UTC (permalink / raw)
To: Yi Zhang; +Cc: linux-block@vger.kernel.org, yangx.jy@fujitsu.com
On Jun 30, 2022 / 17:56, Yi Zhang wrote:
> The rxe/siw driver will be bind to NO-CARRIER interface which lead
> nvmeof-mp/001 failed.
> For example, nvmeof-mp/001 with two NICs, if will output
> count_devices(): 1 <> 2 when the second NIC has NO-CARRIER
>
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
Thanks, applied.
--
Shin'ichiro Kawasaki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-01 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-30 9:56 [PATCH blktests] common/multipath-over-rdma: skip NO-CARRIER NIC when start_soft_rdma Yi Zhang
2022-06-30 15:43 ` Bart Van Assche
2022-07-01 13:46 ` Shinichiro Kawasaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).