public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 02/16] block: call blk_queue_free_zone_bitmaps from disk_release
Date: Wed,  6 Jul 2022 09:03:36 +0200	[thread overview]
Message-ID: <20220706070350.1703384-3-hch@lst.de> (raw)
In-Reply-To: <20220706070350.1703384-1-hch@lst.de>

The zone bitmaps are only used for non-passthrough I/O, so free them as
soon as the disk is released.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 block/blk-sysfs.c | 2 --
 block/genhd.c     | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 58cb9cb9f48cd..7590810cf13fc 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -776,8 +776,6 @@ static void blk_release_queue(struct kobject *kobj)
 	blk_free_queue_stats(q->stats);
 	kfree(q->poll_stat);
 
-	blk_queue_free_zone_bitmaps(q);
-
 	if (queue_is_mq(q))
 		blk_mq_release(q);
 
diff --git a/block/genhd.c b/block/genhd.c
index b1fb7e058b9cc..d0bdeb93e922c 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1165,6 +1165,7 @@ static void disk_release(struct device *dev)
 
 	disk_release_events(disk);
 	kfree(disk->random);
+	blk_queue_free_zone_bitmaps(disk->queue);
 	xa_destroy(&disk->part_tbl);
 
 	disk->queue->disk = NULL;
-- 
2.30.2


  parent reply	other threads:[~2022-07-06  7:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  7:03 clean up zoned device information v2 Christoph Hellwig
2022-07-06  7:03 ` [PATCH 01/16] block: remove a superflous ifdef in blkdev.h Christoph Hellwig
2022-07-06  7:03 ` Christoph Hellwig [this message]
2022-07-06  7:03 ` [PATCH 03/16] block: use bdev_is_zoned instead of open coding it Christoph Hellwig
2022-07-06  7:03 ` [PATCH 04/16] block: simplify blk_mq_plug Christoph Hellwig
2022-07-06  7:03 ` [PATCH 05/16] block: simplify blk_check_zone_append Christoph Hellwig
2022-07-06  7:03 ` [PATCH 06/16] block: pass a gendisk to blk_queue_set_zoned Christoph Hellwig
2022-07-06  7:03 ` [PATCH 07/16] block: pass a gendisk to blk_queue_clear_zone_settings Christoph Hellwig
2022-07-06  7:03 ` [PATCH 08/16] block: pass a gendisk to blk_queue_free_zone_bitmaps Christoph Hellwig
2022-07-06  7:03 ` [PATCH 09/16] block: remove queue_max_open_zones and queue_max_active_zones Christoph Hellwig
2022-07-06  7:03 ` [PATCH 10/16] block: pass a gendisk to blk_queue_max_open_zones and blk_queue_max_active_zones Christoph Hellwig
2022-07-06  7:03 ` [PATCH 11/16] block: replace blkdev_nr_zones with bdev_nr_zones Christoph Hellwig
2022-07-06 11:59   ` Damien Le Moal
2022-07-06  7:03 ` [PATCH 12/16] block: use bdev based helpers in blkdev_zone_mgmt{,all} Christoph Hellwig
2022-07-06  7:03 ` [PATCH 13/16] nvmet:: use bdev based helpers in nvmet_bdev_zone_mgmt_emulate_all Christoph Hellwig
2022-07-06 11:59   ` Damien Le Moal
2022-07-06  7:03 ` [PATCH 14/16] dm-zoned: cleanup dmz_fixup_devices Christoph Hellwig
2022-07-06  7:03 ` [PATCH 15/16] block: remove blk_queue_zone_sectors Christoph Hellwig
2022-07-06  7:03 ` [PATCH 16/16] block: move zone related fields to struct gendisk Christoph Hellwig
2022-07-06 12:46 ` clean up zoned device information v2 Jens Axboe
2022-07-08  4:16 ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706070350.1703384-3-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox