From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7E9C433EF for ; Thu, 21 Jul 2022 06:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbiGUGmL (ORCPT ); Thu, 21 Jul 2022 02:42:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiGUGmK (ORCPT ); Thu, 21 Jul 2022 02:42:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC4415A14D for ; Wed, 20 Jul 2022 23:42:08 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C4DB268AFE; Thu, 21 Jul 2022 08:42:04 +0200 (CEST) Date: Thu, 21 Jul 2022 08:42:04 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Jens Axboe , "linux-block@vger.kernel.org" Subject: Re: [PATCH 4/5] block: move bio_allowed_max_sectors to blk-merge.c Message-ID: <20220721064204.GA21117@lst.de> References: <20220720142456.1414262-1-hch@lst.de> <20220720142456.1414262-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 21, 2022 at 06:31:24AM +0000, Johannes Thumshirn wrote: > On 20.07.22 16:25, Christoph Hellwig wrote: > > +/* > > + * The max size one bio can handle is UINT_MAX becasue bvec_iter.bi_size > > + * is defined as 'unsigned int', meantime it has to aligned to with logical > > + * block size which is the minimum accepted unit by hardware. > > + */ > > Not your call, as your only moving the comment but 'to be aligned to' I'm perfectly fine with fixing it, but a little to lazy to resend just for that :)