From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/2] ublk_drv: store device parameters
Date: Mon, 25 Jul 2022 08:42:59 +0200 [thread overview]
Message-ID: <20220725064259.GA20796@lst.de> (raw)
In-Reply-To: <20220723150713.750369-2-ming.lei@redhat.com>
On Sat, Jul 23, 2022 at 11:07:12PM +0800, Ming Lei wrote:
> One important goal of ublk is to provide generic framework for
> making one block device by userspace.
>
> As one generic block device, there are still lots of parameters,
> such as max_sectors, write_cache/fua, discard related limits,
> zoned parameters, ...., so this patch starts to store & retrieve
> device parameters and prepares for implementing ctrl command of
> SET/GET_DEV_PARAMETERS.
>
> Device parameters have to be stored somewhere, one reason is that
> disk/queue won't be allocated until START_DEV command is received,
> but device parameters have to setup before starting device.
This seems rather overeingeering and really hard to read. Any reason
to not simply open code the parameter verification and application
and do away with the xarray and all the boiler plate code?
next prev parent reply other threads:[~2022-07-25 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 15:07 [PATCH 0/2] ublk_drv: add generic mechanism to get/set parameters Ming Lei
2022-07-23 15:07 ` [PATCH 1/2] ublk_drv: store device parameters Ming Lei
2022-07-25 6:42 ` Christoph Hellwig [this message]
2022-07-25 7:06 ` Ming Lei
2022-07-26 12:32 ` Christoph Hellwig
2022-07-26 14:21 ` Ming Lei
2022-07-26 17:47 ` Christoph Hellwig
2022-07-27 0:12 ` Ming Lei
2022-07-23 15:07 ` [PATCH 2/2] ublk_drv: add SET_PARA/GET_PARA control command Ming Lei
2022-07-25 6:45 ` Christoph Hellwig
2022-07-25 7:07 ` Ming Lei
2022-07-25 6:47 ` [PATCH 0/2] ublk_drv: add generic mechanism to get/set parameters Christoph Hellwig
2022-07-25 7:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725064259.GA20796@lst.de \
--to=hch@lst.de \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).