From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99383C3F6B0 for ; Tue, 26 Jul 2022 17:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234155AbiGZRo7 (ORCPT ); Tue, 26 Jul 2022 13:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiGZRo7 (ORCPT ); Tue, 26 Jul 2022 13:44:59 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4536F1001; Tue, 26 Jul 2022 10:44:58 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AFD5668AA6; Tue, 26 Jul 2022 19:44:54 +0200 (CEST) Date: Tue, 26 Jul 2022 19:44:54 +0200 From: Christoph Hellwig To: Dan Carpenter Cc: Ming Lei , Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ublk_drv: fix double shift bug Message-ID: <20220726174454.GA13897@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig although as-is I would not call it a bug yet as we're not going out of unsigned long range yet.