From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/6] block: change the blk_queue_split calling convention
Date: Wed, 27 Jul 2022 17:52:02 +0200 [thread overview]
Message-ID: <20220727155202.GA18260@lst.de> (raw)
In-Reply-To: <219efcde-fbdb-d379-5c14-874490f8c886@opensource.wdc.com>
On Wed, Jul 27, 2022 at 08:26:13AM +0900, Damien Le Moal wrote:
> > /* there isn't chance to merge the splitted bio */
> > split->bi_opf |= REQ_NOMERGE;
> >
> > - blkcg_bio_issue_init(split);
>
> Is removing this init call intentional ? If yes, isn't that a problem ?
No. This was actually added back in the drivers-post tree by
"block: fix missing blkcg_bio_issue_init" and I messed up the rebase.
Jens, do you want me to send a fixup, or are you going to do it locally?
next prev parent reply other threads:[~2022-07-27 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 18:30 bio splitting cleanups v3 Christoph Hellwig
2022-07-26 18:30 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
2022-07-26 23:26 ` Damien Le Moal
2022-07-27 15:52 ` Christoph Hellwig [this message]
2022-07-27 16:03 ` Jens Axboe
2022-07-27 15:01 ` Jens Axboe
2022-07-26 18:30 ` [PATCH 2/6] block: change the blk_queue_bounce " Christoph Hellwig
2022-07-26 23:27 ` Damien Le Moal
2022-07-27 6:34 ` Johannes Thumshirn
2022-07-26 18:30 ` [PATCH 3/6] block: move ->bio_split to the gendisk Christoph Hellwig
2022-07-26 18:30 ` [PATCH 4/6] block: move the call to get_max_io_size out of blk_bio_segment_split Christoph Hellwig
2022-07-26 18:30 ` [PATCH 5/6] block: move bio_allowed_max_sectors to blk-merge.c Christoph Hellwig
2022-07-26 18:30 ` [PATCH 6/6] block: pass struct queue_limits to the bio splitting helpers Christoph Hellwig
2022-07-26 18:33 ` bio splitting cleanups v3 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-07-27 16:22 bio splitting cleanups v4 Christoph Hellwig
2022-07-27 16:22 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
2022-07-27 16:29 ` Jens Axboe
2022-07-28 1:53 ` Damien Le Moal
2022-07-28 7:55 ` Hannes Reinecke
2022-07-23 6:28 bio splitting cleanups v2 Christoph Hellwig
2022-07-23 6:28 ` [PATCH 1/6] block: change the blk_queue_split calling convention Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727155202.GA18260@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).