From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Chao Leng <lengchao@huawei.com>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
kbusch@kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 0/3] improve nvme quiesce time for large amount of namespaces
Date: Tue, 2 Aug 2022 15:38:15 +0200 [thread overview]
Message-ID: <20220802133815.GA380@lst.de> (raw)
In-Reply-To: <fc7a303f-0921-f784-a559-f03511f2e4be@grimberg.me>
On Sun, Jul 31, 2022 at 01:23:36PM +0300, Sagi Grimberg wrote:
> But maybe we can avoid that, and because we allocate
> the connect_q ourselves, and fully know that it should
> not be apart of the tagset quiesce, perhaps we can introduce
> a new interface like:
> --
> static inline int nvme_ctrl_init_connect_q(struct nvme_ctrl *ctrl)
> {
> ctrl->connect_q = blk_mq_init_queue_self_quiesce(ctrl->tagset);
> if (IS_ERR(ctrl->connect_q))
> return PTR_ERR(ctrl->connect_q);
> return 0;
> }
> --
>
> And then blk_mq_quiesce_tagset can simply look into a per request-queue
> self_quiesce flag and skip as needed.
I'd just make that a queue flag set after allocation to keep the
interface simple, but otherwise this seems like the right thing
to do.
next prev parent reply other threads:[~2022-08-02 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 7:39 [PATCH 0/3] improve nvme quiesce time for large amount of namespaces Chao Leng
2022-07-29 7:39 ` [PATCH 1/3] blk-mq: delete unnecessary comments Chao Leng
2022-07-29 7:39 ` [PATCH 2/3] nvme: improve the quiesce time for non blocking transports Chao Leng
2022-07-29 7:39 ` [PATCH 3/3] nvme: improve the quiesce time for " Chao Leng
2022-07-29 14:26 ` [PATCH 0/3] improve nvme quiesce time for large amount of namespaces Christoph Hellwig
2022-07-30 0:39 ` Chao Leng
2022-07-31 10:23 ` Sagi Grimberg
2022-08-01 1:45 ` Chao Leng
2022-08-02 13:38 ` Christoph Hellwig [this message]
2022-10-10 8:46 ` Chao Leng
2022-10-12 6:37 ` Sagi Grimberg
2022-10-12 8:43 ` Chao Leng
2022-10-12 11:13 ` Sagi Grimberg
2022-10-13 1:37 ` Chao Leng
2022-10-13 2:06 ` Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802133815.GA380@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).